Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional type checking #369

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

cjbarth
Copy link
Contributor

@cjbarth cjbarth commented Jul 31, 2023

Add stronger type definitions and calls to validate the type of the objects we're working with, especially Node types.

@cjbarth cjbarth added the chore label Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #369 (2eb1a39) into master (2e9cbf1) will increase coverage by 1.51%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
+ Coverage   72.38%   73.90%   +1.51%     
==========================================
  Files           9        9              
  Lines         862      866       +4     
  Branches      229      230       +1     
==========================================
+ Hits          624      640      +16     
+ Misses        138      135       -3     
+ Partials      100       91       -9     
Files Changed Coverage Δ
src/c14n-canonicalization.ts 50.42% <70.00%> (-0.87%) ⬇️
src/signed-xml.ts 76.50% <72.72%> (+2.31%) ⬆️
src/utils.ts 85.04% <100.00%> (+1.08%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cjbarth cjbarth merged commit 226e0b2 into node-saml:master Jul 31, 2023
8 of 9 checks passed
@cjbarth cjbarth deleted the add-checks branch July 31, 2023 20:38
@cjbarth cjbarth changed the title Add type checking Add additional type checking Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant