Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce public interface by making some methods private #394

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

cjbarth
Copy link
Contributor

@cjbarth cjbarth commented Oct 6, 2023

Every method was public, but wasn't designed to be. Methods that weren't used in tests are marked as private in this PR.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #394 (9f68078) into master (b0f00d0) will increase coverage by 1.47%.
Report is 1 commits behind head on master.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
+ Coverage   72.98%   74.46%   +1.47%     
==========================================
  Files           9        9              
  Lines         881      881              
  Branches      235      234       -1     
==========================================
+ Hits          643      656      +13     
+ Misses        149      132      -17     
- Partials       89       93       +4     
Files Coverage Δ
src/types.ts 90.00% <ø> (ø)
src/utils.ts 85.18% <100.00%> (+0.13%) ⬆️
src/enveloped-signature.ts 82.60% <50.00%> (+0.79%) ⬆️
src/exclusive-canonicalization.ts 77.34% <50.00%> (ø)
src/c14n-canonicalization.ts 52.10% <25.00%> (ø)
src/signed-xml.ts 77.37% <54.54%> (+3.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cjbarth cjbarth merged commit c2b8cd6 into node-saml:master Oct 6, 2023
8 of 9 checks passed
@cjbarth cjbarth deleted the make_private branch October 6, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant