Enhance derToPem to support XML pretty-print #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #439 +/- ##
=======================================
Coverage 73.17% 73.17%
=======================================
Files 9 9
Lines 902 902
Branches 239 239
=======================================
Hits 660 660
Misses 143 143
Partials 99 99 ☔ View full report in Codecov by Sentry. |
|
@LoneRifle , this should be a simple change to review. It simply removes spaces from a pretty-printed XML payload so that the cert can be properly normalized. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pulling this library to
node-saml, it was discovered that there was a missing case inderToPem. This case is not being handled correctly and a test has been added for it.