Skip to content

Commit

Permalink
support es6 arrow functions, fixes #389 (#393)
Browse files Browse the repository at this point in the history
  • Loading branch information
kivlor authored and Vitaly Puzrin committed Feb 15, 2018
1 parent bee7e99 commit c62fd62
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 3 deletions.
6 changes: 4 additions & 2 deletions lib/js-yaml/type/js/function.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ function resolveJavascriptFunction(data) {
if (ast.type !== 'Program' ||
ast.body.length !== 1 ||
ast.body[0].type !== 'ExpressionStatement' ||
ast.body[0].expression.type !== 'FunctionExpression') {
(ast.body[0].expression.type !== 'ArrowFunctionExpression' &&
ast.body[0].expression.type !== 'FunctionExpression')) {
return false;
}

Expand All @@ -51,7 +52,8 @@ function constructJavascriptFunction(data) {
if (ast.type !== 'Program' ||
ast.body.length !== 1 ||
ast.body[0].type !== 'ExpressionStatement' ||
ast.body[0].expression.type !== 'FunctionExpression') {
(ast.body[0].expression.type !== 'ArrowFunctionExpression' &&
ast.body[0].expression.type !== 'FunctionExpression')) {
throw new Error('Failed to resolve function');
}

Expand Down
5 changes: 5 additions & 0 deletions test/samples-common/construct-javascript-function.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ function testHandler(actual) {

assert.strictEqual(actual.length, expected.length);

assert.strictEqual(actual.length, expected.length);

assert.strictEqual(
actual[0](),
expected[0]());
Expand All @@ -26,6 +28,9 @@ testHandler.expected = [
function () {
return 42;
},
function () {
return 72;
},
function (x, y) {
return x + y;
},
Expand Down
3 changes: 2 additions & 1 deletion test/samples-common/construct-javascript-function.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
- !!js/function 'function () { return 42 }'
- !!js/function '() => { return 72 }'
- !!js/function 'function (x, y) { return x + y; } '
- !!js/function |
function (foo) {
Expand All @@ -9,4 +10,4 @@
second: 'sum',
third: result
};
}
}

0 comments on commit c62fd62

Please sign in to comment.