Check for leading newlines when determining if block indentation indicator is needed #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cator is needed Fixes nodeca#403
aepsilon
reviewed
Mar 16, 2018
lib/js-yaml/dumper.js
Outdated
| @@ -301,7 +307,7 @@ function chooseScalarStyle(string, singleLineOnly, indentPerLevel, lineWidth, te | |||
| ? STYLE_PLAIN : STYLE_SINGLE; | |||
| } | |||
| // Edge case: block indentation indicator can only have one digit. | |||
| if (string[0] === ' ' && indentPerLevel > 9) { | |||
| if (needIndentIndicator(string) && indentPerLevel > 9) { | |||
There was a problem hiding this comment.
Looking back, an optimization would be to short-circuit by first comparing indentPerLevel > 9, because it's almost always something like 2, 4, or 8. Likely not a big deal though.
There was a problem hiding this comment.
Makes sense. I'm happy to change it, or you can.
|
Thanks! |
minj
added a commit
to minj/js-yaml
that referenced
this pull request
Apr 28, 2018
* master: (58 commits) Check for leading newlines when determining if block indentation indicator is needed (nodeca#404) Add property based tests to assess load reverses dump (nodeca#398) 3.11.0 released Browser files rebuild Dumper: fix negative integers in bin/octal/hex formats, close nodeca#399 support es6 arrow functions, fixes nodeca#389 (nodeca#393) Fix typo in README.md (nodeca#373) 3.10.0 released Browser files rebuild Add test for astrals dump Combine surrogate pairs into one escape sequence when encoding. (nodeca#369) Fix condenseFlow for objects (nodeca#371) correct spelling mistake (nodeca#367) More meaningful error for loader (nodeca#361) Fix typo and format code. (nodeca#365) 3.9.1 released Browser files rebuild Ensure stack is present for custom errors (fixes nodeca#351) (nodeca#360) 3.9.0 released Browser files rebuild ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #403