Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominating @RichardLau for Releasers team #585

Closed
BethGriggs opened this issue Jun 10, 2020 · 9 comments
Closed

Nominating @RichardLau for Releasers team #585

BethGriggs opened this issue Jun 10, 2020 · 9 comments

Comments

@BethGriggs
Copy link
Member

Socialised via email to the @nodejs/tsc as per:

Release authorization is given by the Node.js TSC.

@MylesBorins
Copy link
Contributor

+1!!!

@mcollina
Copy link
Member

+1

@codebytere
Copy link
Member

+1!

@mhdawson
Copy link
Member

+1

BethGriggs added a commit to BethGriggs/Release that referenced this issue Jun 19, 2020
@BethGriggs
Copy link
Member Author

BethGriggs commented Jun 19, 2020

Raised #588 and added to the team.

@richardlau, it is worth running through the 'Who Can Make A Release?' section. Please let me know if there is any access that requires someone with admin permissions to grant.

I'm also assuming you do not yet have access to https://github.com/nodejs-private/node-private for security releases. I do not know the process of adding releasers to that organisation. Can anyone from @nodejs/releasers confirm it is just a case of inviting Richard to the GitHub organisation and relevant teams?

@richardlau
Copy link
Member

richardlau commented Jun 19, 2020

@BethGriggs According to the process in https://github.com/nodejs/Release/blob/master/GOVERNANCE.md being added to the team happens after preparing a release? Or maybe the ordering doesn't matter if there are no objections (in which case we should update the docs)?

I can confirm I currently do not have access to https://github.com/nodejs-private/node-private.

FWIW I've been trying to add my gpg key to the public keyservers (via the submission link in https://github.com/nodejs/node/blob/master/doc/guides/releases.md#3-a-publicly-listed-gpg-key) but so far haven't been able to retrieve it via the command.

@BethGriggs
Copy link
Member Author

BethGriggs commented Jun 19, 2020

Converted #588 back to a draft and hold off with accesses until the first release is prepared.

I think the wording can be improved, as the following implied to me that the new releaser would kick off the builds (which you need to be in the release team for). Although, I think you have ci-release access via the Build WG anyway.

The nominee will then be expected to prepare one release on any active release line, which can be tagged, signed and promoted by any other existing member of the releasers team.

It would probably also be worth refactoring releases.md or adding a reference back to the Release governance documentation as they seem to overlap.

The nominee will then be expected to prepare one release on any active release line.

There are probably enough commits and backports to warrant preparing a v10.x release.

@nschonni
Copy link
Member

https://github.com/nodejs/docker-node/blob/master/keys/node.keys probably also needs to be updated, but I didn't see that in the release.md.

@richardlau
Copy link
Member

https://github.com/nodejs/docker-node/blob/master/keys/node.keys probably also needs to be updated, but I didn't see that in the release.md.

It’s listed in https://github.com/nodejs/Release/blob/master/GOVERNANCE.md#adding-new-releasers. As @BethGriggs said it’s probably worth refactoring release.md.

richardlau added a commit to richardlau/docker-node that referenced this issue Jul 16, 2020
richardlau added a commit to richardlau/node-1 that referenced this issue Jul 20, 2020
Add Richard Lau and his Release key.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: nodejs#34397
Refs: nodejs/Release#585
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
cjihrig pushed a commit to nodejs/node that referenced this issue Jul 23, 2020
Add Richard Lau and his Release key.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #34397
Refs: nodejs/Release#585
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Jul 27, 2020
Add Richard Lau and his Release key.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #34397
Refs: nodejs/Release#585
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
richardlau pushed a commit that referenced this issue Jul 29, 2020
addaleax pushed a commit to nodejs/node that referenced this issue Sep 22, 2020
Add Richard Lau and his Release key.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #34397
Refs: nodejs/Release#585
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax pushed a commit to nodejs/node that referenced this issue Sep 22, 2020
Add Richard Lau and his Release key.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #34397
Refs: nodejs/Release#585
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
richardlau added a commit to nodejs/node that referenced this issue Jan 8, 2021
Add Richard Lau and his Release key.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #34397
Refs: nodejs/Release#585
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants
@mcollina @MylesBorins @nschonni @codebytere @richardlau @BethGriggs @mhdawson and others