Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix meeting minute dates #255

Merged
merged 1 commit into from
Sep 25, 2017
Merged

Conversation

gibfahn
Copy link
Member

@gibfahn gibfahn commented Sep 25, 2017

Fixes: #253

cc/ @mjomble, let me know if this LGTY.

You can check the meeting issues here: https://github.com/nodejs/Release/issues?q=is%3Aissue+is%3Aclosed+label%3Alts-meeting

@mjomble
Copy link

mjomble commented Sep 25, 2017

In the case of 2017-04-24.md, 2017-03-13.md suggests that April 4 might have been correct and it was the filename that was wrong.
However, I'm not sure, perhaps the meeting was actually later rescheduled for the 24th.

The rest looks good, assuming that these are the correct dates :)

@mjomble
Copy link

mjomble commented Sep 25, 2017

Ah, from #201 it seems like 24 was indeed correct.

@gibfahn
Copy link
Member Author

gibfahn commented Sep 25, 2017

In the case of 2017-04-24.md, 2017-03-13.md suggests that April 4 might have been correct and it was the filename that was wrong.

Good point, adjusted the Next meeting dates too.

@@ -3,7 +3,7 @@
- [Github Issue](https://github.com/nodejs/LTS/issues/233)
- [Meeting Video](https://www.youtube.com/watch?v=xSo6YiKzc5M)
- [Previous meeting](https://github.com/nodejs/LTS/issues/225)
- Next meeting: 17 July 2017
- Next meeting: 19 July 2017
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 19 September?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what I was doing here, it should actually have been the 17th of July, see #235.

The meeting was cancelled, but we didn't know that at the time.

@mjomble
Copy link

mjomble commented Sep 25, 2017

Looks good now 👍

@gibfahn gibfahn merged commit a234c71 into nodejs:master Sep 25, 2017
@gibfahn gibfahn deleted the meeting-dates branch September 25, 2017 15:29
ChALkeR pushed a commit to ChALkeR/LTS that referenced this pull request Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date mismatches on meeting notes
3 participants