Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add meeting 10 Jan 2024 #1490

Merged
merged 2 commits into from
Jan 17, 2024
Merged

doc: add meeting 10 Jan 2024 #1490

merged 2 commits into from
Jan 17, 2024

Conversation

mhdawson
Copy link
Member

No description provided.

Signed-off-by: Michael Dawson <midawson@redhat.com>
* Ruy, definitely going to be a large breaking change
* Geoffrey, the person who wants to champion removal of npm should write up proposal and
then we vote on that.
* Ruy, has been mentioned that distributing npm as are of corepack might not be legally ok.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does corepack actually redistribute npm, or does it just fetch it from the registry?

See related nodejs/corepack#104 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@styfle I think thats a reasonable question, but the notes are meant to record what Ruy say so I don't think we necessarily need to update them to answer the question.

Copy link
Member

@styfle styfle Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

I came here from nodejs/corepack#104 (comment)

I just didn't know where to leave comments at the time.

I think probably here: nodejs/node#50963

@mhdawson
Copy link
Member Author

@nodejs/tsc could I get an approval or two so that I can land this?

@mhdawson mhdawson merged commit 1d22960 into nodejs:main Jan 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants