Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidance to proposal section #53

Closed
wants to merge 2 commits into from
Closed

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Mar 1, 2016

Add additional guiance to proposal section to call out
that proposals need to explain how the project will
better the Node.js ecosystem.

@feross
Copy link

feross commented Mar 1, 2016

👍

@feross
Copy link

feross commented Mar 1, 2016

I'd also like to see a bit about why a project would want to join the foundation, i.e. what they can expect from the process and why they might want that.

* what set of Node.js users is the project interesting/critical to ?
* is there a direct relationship between the project and core Node.js
or one of the existing top-level projects? For example is it a
Node.js dependency ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if "is it a Node.js dependency" might be misinterpreted. Suggestion "does Node.js itself depend on it"

@orangemocha
Copy link
Contributor

Nit: guiance => guidance in the commit message.

@orangemocha
Copy link
Contributor

This looks like a useful starting point to me. LGTM, with a couple of really tiny nits.

@mikeal
Copy link
Contributor

mikeal commented Mar 2, 2016

These are some good questions.

The state of the docs here need a big re-working to get in-line with what we're already doing. It's very hard to figure out the TSC is doing in practice and what the Incubator is for.

There's also a few tough questions we need to address that I'll be logging over the next few days.

This is all just to say that I think that we should merge this but shortly after re-work the README, this doc, and most of the other docs as well.

mhdawson added 2 commits March 2, 2016 14:24
Add additional guidance to proposal section to call out
that proposals need to explain how the project will
better the Node.js ecosystem.
@mhdawson
Copy link
Member Author

mhdawson commented Mar 2, 2016

Updated to address review comments so far.

@jasnell
Copy link
Member

jasnell commented Mar 3, 2016

LGTM

@mhdawson
Copy link
Member Author

mhdawson commented Mar 9, 2016

Can this be landed ?

@jasnell
Copy link
Member

jasnell commented Mar 9, 2016

Should be safe but let's put it on the tsc-agenda for tomorrow just to be extra safe ;-) I'll land it tomorrow if there are no objections.

@Fishrock123
Copy link
Contributor

TSC has decided to delay this for now while we figure some mission-y things out.

@mhdawson
Copy link
Member Author

mhdawson commented Feb 9, 2017

Don't think this is relevant anymore.

@mhdawson mhdawson closed this Feb 9, 2017
@mhdawson mhdawson deleted the better branch August 14, 2019 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants