Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: change links in ONBOARDING.md #591

Merged
merged 1 commit into from
Sep 3, 2018
Merged

Conversation

gdams
Copy link
Member

@gdams gdams commented Aug 27, 2018

I was reading through the ONBOARDING guide and noticed that it was pointing to @mhdawson's fork. Please close if this was intentional.

@richardlau
Copy link
Member

For some history the link is pointing to where the tool was originally until it was brought under the foundation (#492) so I think this was just an oversight.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to get this fixed, LGTM

@Trott Trott merged commit 0332639 into nodejs:master Sep 3, 2018
@gdams gdams deleted the onboarding branch September 11, 2018 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants