Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get node-addon-api working with version 4.x and 6.x, and older 8.x versions #282

Closed
mhdawson opened this issue Oct 12, 2017 · 2 comments
Closed

Get node-addon-api working with version 4.x and 6.x, and older 8.x versions #282

mhdawson opened this issue Oct 12, 2017 · 2 comments
Assignees
@gabrielschulhof
Milestone
Milestone 9

Comments

@mhdawson
Copy link
Member

No description provided.

@mhdawson mhdawson added this to the Milestone 9 milestone Oct 12, 2017
@mhdawson
Copy link
Member Author

nodejs/node-addon-api#142

@NickNaso
Copy link
Member

On my recent porting of bcrypt all compile well on version previous of 8 but when i requere the module i get an error reported here:
kelektiv/node.bcrypt.js#513 (comment)

kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this issue Aug 24, 2022
@kevindavies8
Fix test errors
d46a1b7 
* Implement node::MakeCallback between 8.0.0 and 8.6.0 to fix
  unresolved symbol
* Fix error message expectation (was: "Invalid pointer", is: "Invalid
  argument")
* Add -fvisibility=hidden to the compilation of sources of node_api.a
  so as to avoid conflicts with Node.js symbols

Fixes: nodejs/node-addon-api#142
Fixes: nodejs/abi-stable-node#282
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this issue Aug 26, 2022
@Marlyfleitas
Fix test errors
d452adc 
* Implement node::MakeCallback between 8.0.0 and 8.6.0 to fix
  unresolved symbol
* Fix error message expectation (was: "Invalid pointer", is: "Invalid
  argument")
* Add -fvisibility=hidden to the compilation of sources of node_api.a
  so as to avoid conflicts with Node.js symbols

Fixes: nodejs/node-addon-api#142
Fixes: nodejs/abi-stable-node#282
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this issue Sep 19, 2022
@wroy7860
Fix test errors
2769452 
* Implement node::MakeCallback between 8.0.0 and 8.6.0 to fix
  unresolved symbol
* Fix error message expectation (was: "Invalid pointer", is: "Invalid
  argument")
* Add -fvisibility=hidden to the compilation of sources of node_api.a
  so as to avoid conflicts with Node.js symbols

Fixes: nodejs/node-addon-api#142
Fixes: nodejs/abi-stable-node#282
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this issue Aug 11, 2023
Fix test errors
ea1f05c 
* Implement node::MakeCallback between 8.0.0 and 8.6.0 to fix
  unresolved symbol
* Fix error message expectation (was: "Invalid pointer", is: "Invalid
  argument")
* Add -fvisibility=hidden to the compilation of sources of node_api.a
  so as to avoid conflicts with Node.js symbols

Fixes: nodejs/node-addon-api#142
Fixes: nodejs/abi-stable-node#282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabrielschulhof gabrielschulhof

Labels
None yet
Projects
None yet
Milestone
Milestone 9
Development

No branches or pull requests
3 participants
@NickNaso @gabrielschulhof @mhdawson