doc: add blurb recommending the use of badges #357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add blurb to N-API documentation indicating that we recommend the use of badges. Fixes: nodejs/node#22796 Fixes: nodejs#333 Re: nodejs/node#22801
gabrielschulhof
force-pushed
the
update-for-badges
branch
from
d8a0d8c to
ee5b235
Compare
NickNaso
reviewed
Jan 9, 2019
README.md
Outdated
|
|
||
| The use of badges is recommended to indicate the minimum version of N-API | ||
| required for the module. This helps to determine which Node.js major versions | ||
| are supported. The following badges are available: |
There was a problem hiding this comment.
What do you think to link here the N-API version matrix https://nodejs.org/dist/latest/docs/api/n-api.html#n_api_n_api_version_matrix ?
gabrielschulhof
pushed a commit
that referenced
this pull request
Jan 19, 2019
Add blurb to N-API documentation indicating that we recommend the use of badges. PR-URL: #357 Fixes: nodejs/node#22796 Fixes: #333 Re: nodejs/node#22801 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
Landed in 0679f65. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add blurb to N-API documentation indicating that we recommend the use
of badges.
Fixes: nodejs/node#22796
Re: nodejs/node#22801
This brings @ddlan's doc additions to the README.md in this repo.