-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow hiding of comments (Moderation Policy udpate) #172
Conversation
Allow Collaborators to use the GitHub "Hide" feature for blatantly off-topic comments. Refs: nodejs/moderation#214
@nodejs/moderation @nodejs/tsc @nodejs/community-committee |
Fwiw, I have used this feature in e.g. nodejs/node#20876 to keep the discussion on track, even for comments that would probably not qualify as “blatantly” off-topic, simply because there was a lot of attention/comments. Maybe we should clarify whether that’s okay or not? Like, the current wording makes it sound like that would not be okay, whereas previously I just assumed that it would be. |
@addaleax Happy to wordsmith it. Was thinking "broad authority" could really just be "authority". I wanted to include an adverb like "clearly" or "blatantly" or "conspicuously" because I can envision a scenario where there is an hide/unhide war between Collaborators who disagree about the off-topic-ness of a comment. In that situation, I think the unhide side should prevail, but maybe I'm imagining a problem that won't happen? Would this work for you?
Then, if this causes issues down the road, we can revisit. But for now, let's allow Collaborators to keep things focused without worrying that they're violating policy? |
Yes, that sounds perfectly fine and a bit clearer to me. :) |
Text updated! |
Thinking about this further, does this mean that collaborators should not hide other collaborators comments? |
Yes, that's right. We already have a mechanism for dealing with Collaborator posts--we ask the Collaborator to edit or delete their own comment. Hiding seems unnecessary but certainly an option if they'd rather hide their own comment. |
@Trott I think hiding outdated comments in PRs should be acceptable - that said this PR doesn't forbid this as far as I can tell (and it's done in cooperation most times anyway and comments can be unhidden). |
@benjamingr Those comments are typically from other Collaborators, so that's a separate issue (and arguably not a moderation issue, although I'd prefer the policy for hiding be all in one place, so I wouldn't push that argument myself). This PR is about non-Collaborators. It's about J. Default Avatar leaving a comment like "hi everyone!" and avoiding the overhead of opening a moderation issue and talking about it and so on. Just hide that comment and go back to work. |
Allow Collaborators to use the GitHub "Hide" feature for
off-topic comments from non-Collaborators.
Refs: https://github.com/nodejs/moderation/issues/214