Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post: v23.4.0 announcement #17

Merged
merged 3 commits into from
Dec 10, 2024
Merged

post: v23.4.0 announcement #17

merged 3 commits into from
Dec 10, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 10, 2024

Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I wish we had a bit more summary about the new features in the text?

(Speaking of which, we should also add the character length limit validation to the workflow).

Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
@joyeecheung
Copy link
Member

joyeecheung commented Dec 10, 2024

I am typing on my phone so I don't know if these fit in 300 chars, but I think this is the list that can be put into the post (maybe we can cut some if it's too long, or we can send a reply to the first post)

  • assert.partialDeepStrictEqual()
  • --trace-env
  • net.BlockList.isBlockList()
  • net.SocketAddress.parse()
  • BlockList support in net.Server and net.connect
  • unflag node:sqlite
  • StatementSync.prototype.iterate()
  • deprecate features.{ipv6,uv} and features.tls_*
  • new collaborator @jordan.har.band

According to my testing in joyeecheung/bluesky-playground#10 line breaks via \n works.

@aduh95
Copy link
Contributor Author

aduh95 commented Dec 10, 2024

Yeah the following text is already 283 char, it would need to be a response – which I think needs to be another PR, I don't think we support making threads

Notable changes:

- `assert.partialDeepStrictEqual()`
- `--trace-env`
- `net.BlockList.isBlockList()`
- `net.SocketAddress.parse()`
- BlockList support in `net.Server` and `net.connect`
- unflag `node:sqlite`
- `StatementSync.prototype.iterate()`
- new Collaborator @jordan.har.band

@joyeecheung
Copy link
Member

How about

Thanks to @targos.dev and @aduh95.bsky.social for a new Node.js Current release!

https://nodejs.org/en/blog/release/v23.4.0

- assert.partialDeepStrictEqual()
- --trace-env
- net.SocketAddress.parse()
- Better net.BlockList support
- unflag node:sqlite
- StatementSync.prototype.iterate()

It's 289 chars, and we can add new Collaborator @jordan.har.band to a separate post

@joyeecheung
Copy link
Member

(Also another note, we can support file reference in the JSON, so that the rich text content can be put into a .txt, and the workflow can read it and JSON.stringify it)

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@joyeecheung
Copy link
Member

@joyeecheung joyeecheung merged commit 53ca786 into main Dec 10, 2024
1 check passed
@joyeecheung joyeecheung deleted the v23.4.0-announcement branch December 10, 2024 18:22
@joyeecheung joyeecheung restored the v23.4.0-announcement branch December 10, 2024 18:23
@joyeecheung
Copy link
Member

It seems the branch deletion is automatic, after some googling I found

https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-the-automatic-deletion-of-branches

So I disabled it in the repo setting.

joyeecheung added a commit that referenced this pull request Dec 10, 2024
* post: v23.4.0 announcement

* Update records/new/v23.4.0-announcement.json

Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>

* Update records/new/v23.4.0-announcement.json

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

---------

Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
joyeecheung added a commit that referenced this pull request Dec 10, 2024
* post: v23.4.0 announcement (#17)

* post: v23.4.0 announcement

* Update records/new/v23.4.0-announcement.json

Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>

* Update records/new/v23.4.0-announcement.json

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

---------

Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>

* Update v23.4.0-announcement.json

---------

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@joyeecheung
Copy link
Member

About new Collaborator @jordan.har.band

It seems a repost of https://bsky.app/profile/jordan.har.band/post/3lcixvbt24k2e is more apt?

@aduh95 aduh95 deleted the v23.4.0-announcement branch December 10, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants