use GraphQL call instead of git push
#27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we actually care about signed commit shere? And what's the downside of git push in the workflow? I do find the current format easier to read/debug, and easy to replicate/test locally. |
|
Yeah I kinda agree, it started as a simple idea, but it turned out to be more complicated than I envisioned. Let's keep the current approach for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we care about restricting
git pushin the workflow and create a signed commit, we can use a GraphQL API call instead ofgit push.I've tested it with https://github.com/TestOrgPleaseIgnore/bluesky/actions/runs/12287645499/job/34290039602, which created TestOrgPleaseIgnore@b10d255