Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sent test post to verify that the automation works #5

Closed
wants to merge 2 commits into from

Conversation

joyeecheung
Copy link
Member

Funny enough I realized that the review guidelines didn't include this type of content, so I edited it a bit to add an exception 😅

Note the scripts aren't powerful enough to generate thumbnails yet (if you used links in bluesky before, you may have noticed that the thumbnails are uploaded from cards generated locally, which is also something that the automation needs to implement) but I think that's probably fine, just less visually pleasing but the links can be clickable all the same, it would look similar to https://bsky.app/profile/pixel-voyager.bsky.social/post/3lcbd6z3qh42j and we can work on cards later. Nobody expects the action to be perfect from the first iteration ;)

@joyeecheung
Copy link
Member Author

Needs to get #6 in first or otherwise it doesn't setup corepack properly..

@joyeecheung
Copy link
Member Author

cc @nodejs/tsc

@joyeecheung
Copy link
Member Author

joyeecheung commented Dec 1, 2024

So the validate workflow is failing, and apparently the secrets are not passed into workflow runs triggered by PRs from forks. So I guess that means we should split the validation into two parts:

  1. If it's triggered by a PR from a branch in this repo (which means it must be from someone who already has write access here), it can invoke additional validation to check the URLs are reachable and valid (which requires access to bluesky secrets).
  2. Otherwise, only local validations are run on the JSON files.

I'll close this one and open a new PR from a branch in this repo. Then open another PR to split the validation so that PRs sent from those who don't have write access to this repo can still get some local validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants