-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node-test-node-addon-api-new job hanging? #2131
Comments
The same test hang across multiple platforms - possibly caused by nodejs/node@689ab46?
ping @nodejs/addon-api |
Aborted https://ci.nodejs.org/job/node-test-node-addon-api-new/1616/ and https://ci.nodejs.org/job/node-test-node-addon-api-new/1617/ as they were both hanging. |
Based on the team members listed on https://github.com/nodejs/node-addon-api maybe also ping @nodejs/n-api? |
Does it make sense to turn the timer off on that job until the hanging issue is resolved? I think it is configured to run daily. |
I'll try to look today to see if its the BigInt change and if we need to update the tests. |
Cancelled the current job |
Started by removing 8.x from the tests as is has gone EOL and therefore we've landed some code that no longer works there. |
Next will look at the test so that it accomodates the change in master. |
@mhdawson @nodejs/n-api-admins Any comments on adding a timeout to the node-test-node-addon-api-new build (#2131 (comment))? I've also noticed that node-test-node-addon-api-new runs once a day on the sixth hour: but it's also run once per day by node-test-node-addon-api-LTS versions on the third hour: (e.g. for today https://ci.nodejs.org/job/node-test-node-addon-api-new/1625/ and https://ci.nodejs.org/job/node-test-node-addon-api-new/1623/ (via https://ci.nodejs.org/job/node-test-node-addon-api-LTS%20versions/617/)) Does master need to be tested twice a day? |
nodejs/node@689ab46 changed the expected error for one of the BigInt test cases. This is ok because BigInt is still in experimental. However, the result was a failed/hanging test. See nodejs/build#2131 This changes the test to accept either the new or old behaviour. We need that so that older versions of Node.js will also pass the test until the the node core commit above is backported.
PR to fix test: nodejs/node-addon-api#649 Believe it was also likely the cause of the hang. |
nodejs/node@689ab46 changed the expected error for one of the BigInt test cases. This is ok because BigInt is still in experimental. However, the result was a failed/hanging test. See nodejs/build#2131 This changes the test to accept either the new or old behaviour. We need that so that older versions of Node.js will also pass the test until the the node core commit above is backported. PR-URL: #649 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Landed PR to fix test. Updated the new job to not run on its own so we should now only test master once a day Launched job to test across versions to confirm we are now good |
CI run was good across all versions, closing. @richardlau I'm ok if you enable the option to abort if stuck. |
Added a no activity 3600 second (1 hour) time out. |
nodejs/node@689ab46 changed the expected error for one of the BigInt test cases. This is ok because BigInt is still in experimental. However, the result was a failed/hanging test. See nodejs/build#2131 This changes the test to accept either the new or old behaviour. We need that so that older versions of Node.js will also pass the test until the the node core commit above is backported. PR-URL: nodejs#649 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
nodejs/node@689ab46 changed the expected error for one of the BigInt test cases. This is ok because BigInt is still in experimental. However, the result was a failed/hanging test. See nodejs/build#2131 This changes the test to accept either the new or old behaviour. We need that so that older versions of Node.js will also pass the test until the the node core commit above is backported. PR-URL: nodejs#649 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
nodejs/node@689ab46 changed the expected error for one of the BigInt test cases. This is ok because BigInt is still in experimental. However, the result was a failed/hanging test. See nodejs/build#2131 This changes the test to accept either the new or old behaviour. We need that so that older versions of Node.js will also pass the test until the the node core commit above is backported. PR-URL: nodejs/node-addon-api#649 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
nodejs/node@689ab46 changed the expected error for one of the BigInt test cases. This is ok because BigInt is still in experimental. However, the result was a failed/hanging test. See nodejs/build#2131 This changes the test to accept either the new or old behaviour. We need that so that older versions of Node.js will also pass the test until the the node core commit above is backported. PR-URL: nodejs/node-addon-api#649 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
nodejs/node@689ab46 changed the expected error for one of the BigInt test cases. This is ok because BigInt is still in experimental. However, the result was a failed/hanging test. See nodejs/build#2131 This changes the test to accept either the new or old behaviour. We need that so that older versions of Node.js will also pass the test until the the node core commit above is backported. PR-URL: nodejs/node-addon-api#649 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
nodejs/node@689ab46 changed the expected error for one of the BigInt test cases. This is ok because BigInt is still in experimental. However, the result was a failed/hanging test. See nodejs/build#2131 This changes the test to accept either the new or old behaviour. We need that so that older versions of Node.js will also pass the test until the the node core commit above is backported. PR-URL: nodejs/node-addon-api#649 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
It seems like this job is regularly hanging - previous runs have taken between 2-10minutes. The previous run took 7 hours+ and the current run is at 4+ hours.
https://ci.nodejs.org/job/node-test-node-addon-api-new/nodes=fedora-latest-x64/1617/
The text was updated successfully, but these errors were encountered: