Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect Windows incompatible filenames in CI #338

Closed
joaocgreis opened this issue Feb 22, 2016 · 3 comments
Closed

Detect Windows incompatible filenames in CI #338

joaocgreis opened this issue Feb 22, 2016 · 3 comments

Comments

@joaocgreis
Copy link
Member

@nodejs/jenkins-admins

When npm was updated to 3.6.0 in master (nodejs/node#4958), some files were accidentally included that cause git issues checking out in Windows (nodejs/node#5094).

After nodejs/node#5211 nodejs/node#5369 or nodejs/node#5212 land, I plan to add this to node-compile-windows, to prevent the same problem from happening again:

:: https://github.com/nodejs/node/issues/5094
ECHO OFF
FOR /F %%F IN ('git status --porcelain') DO (
  git status
  echo.
  echo ERROR: Workspace cannot be cleaned, possible problem with committed file names
  exit /b 1
)
ECHO ON

Tests:

@rvagg
Copy link
Member

rvagg commented Feb 23, 2016

great, tho I'm wondering if we shouldn't @ that or something to prevent the "ERROR" text from showing up even when it's working fine, a quick scan or a ctrl-f will show up that text and may be easy to misread.

@joaocgreis
Copy link
Member Author

Added ECHO OFF/ON instead to make it clear that something is happening behind the scenes.

@joaocgreis
Copy link
Member Author

Added to job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants