Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File names in readable_stream folder are not supported in Windows #5094

Closed
kunalspathak opened this issue Feb 4, 2016 · 7 comments
Closed

File names in readable_stream folder are not supported in Windows #5094

kunalspathak opened this issue Feb 4, 2016 · 7 comments
Labels
npm Issues and PRs related to the npm client dependency or the npm registry. windows Issues and PRs related to the Windows platform.

Comments

@kunalspathak
Copy link
Member

If I clone nodejs/master and do git status git complains bunch of files are added/deleted. The reason is 76cb81b added files in readable_stream with names that are not allowed in Windows. When git clones the repo, it silently renames it. Can we fix that sooner so git is clean when they fetch new contents from nodejs/master?

I could fix it if i know what are the right names of these files.

[fs](x86chk) E:\git>git clone https://github.com/nodejs/node.git deletethis
Cloning into 'deletethis'...
remote: Counting objects: 199414, done.
remote: Compressing objects: 100% (25/25), done.
remote: Total 199414 (delta 12), reused 0 (delta 0), pack-reused 199389
Receiving objects: 100% (199414/199414), 170.71 MiB | 30.25 MiB/s, done.
Resolving deltas: 100% (146367/146367), done.
Checking connectivity... done.
Checking out files: 100% (16833/16833), done.

[fs](x86chk) E:\git>cd E:\git\deletethis\deps\npm\node_modules\readable-stream

[deletethis/master](x86chk) E:\git\deletethis\deps\npm\node_modules\readable-stream>git status .
On branch master
Your branch is up-to-date with 'origin/master'.
Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

        deleted:    .npmignore~8d21794... deps: upgrade npm to 3.6.0
        deleted:    LICENSE~8d21794... deps: upgrade npm to 3.6.0
        deleted:    LICENSE~8d21794... deps: upgrade npm to 3.6.0_0
        deleted:    duplex.js~8d21794... deps: upgrade npm to 3.6.0
        deleted:    node_modules/core-util-is/README.md~8d21794... deps: upgrade npm to 3.6.0
        deleted:    node_modules/core-util-is/float.patch~8d21794... deps: upgrade npm to 3.6.0
        deleted:    node_modules/core-util-is/lib/util.js~8d21794... deps: upgrade npm to 3.6.0
        deleted:    node_modules/isarray/README.md~8d21794... deps: upgrade npm to 3.6.0
        deleted:    node_modules/isarray/component.json~8d21794... deps: upgrade npm to 3.6.0
        deleted:    node_modules/isarray/index.js~8d21794... deps: upgrade npm to 3.6.0
        deleted:    node_modules/string_decoder/.npmignore~8d21794... deps: upgrade npm to 3.6.0
        deleted:    node_modules/string_decoder/LICENSE~8d21794... deps: upgrade npm to 3.6.0
        deleted:    node_modules/string_decoder/README.md~8d21794... deps: upgrade npm to 3.6.0
        deleted:    node_modules/string_decoder/index.js~8d21794... deps: upgrade npm to 3.6.0
        deleted:    passthrough.js~8d21794... deps: upgrade npm to 3.6.0
        deleted:    transform.js~8d21794... deps: upgrade npm to 3.6.0
        deleted:    writable.js~8d21794... deps: upgrade npm to 3.6.0

Untracked files:
  (use "git add <file>..." to include in what will be committed)

        .npmignore~8d21794... deps
        LICENSE~8d21794... deps
        duplex.js~8d21794... deps
        node_modules/core-util-is/README.md~8d21794... deps
        node_modules/core-util-is/float.patch~8d21794... deps
        node_modules/core-util-is/lib/util.js~8d21794... deps
        node_modules/isarray/README.md~8d21794... deps
        node_modules/isarray/component.json~8d21794... deps
        node_modules/isarray/index.js~8d21794... deps
        node_modules/string_decoder/.npmignore~8d21794... deps
        node_modules/string_decoder/LICENSE~8d21794... deps
        node_modules/string_decoder/README.md~8d21794... deps
        node_modules/string_decoder/index.js~8d21794... deps
        passthrough.js~8d21794... deps
        transform.js~8d21794... deps
        writable.js~8d21794... deps
@mscdex mscdex added windows Issues and PRs related to the Windows platform. npm Issues and PRs related to the npm client dependency or the npm registry. labels Feb 5, 2016
@mscdex
Copy link
Contributor

mscdex commented Feb 5, 2016

/cc @iarna @zkat

@mscdex
Copy link
Contributor

mscdex commented Feb 5, 2016

I can confirm this as well. Although I get errors during clone even:

Cloning into 'deletethis'...
remote: Counting objects: 199429, done.
remote: Compressing objects: 100% (4/4), done.
Receiving objects: 100% (199429/199429), 170.83 MiB | 212.00 KiB/s, done.eiving objects: 100% (199429/199429), 170.81 MiB | 216.00 KiB/s

Resolving deltas: 100% (146377/146377), done.
Checking connectivity... done.
error: Invalid path 'deps/npm/node_modules/readable-stream/.npmignore~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/LICENSE~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/LICENSE~8d21794... deps: upgrade npm to 3.6.0_0'
error: Invalid path 'deps/npm/node_modules/readable-stream/duplex.js~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/node_modules/core-util-is/README.md~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/node_modules/core-util-is/float.patch~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/node_modules/core-util-is/lib/util.js~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/node_modules/isarray/README.md~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/node_modules/isarray/component.json~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/node_modules/isarray/index.js~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/node_modules/string_decoder/.npmignore~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/node_modules/string_decoder/LICENSE~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/node_modules/string_decoder/README.md~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/node_modules/string_decoder/index.js~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/passthrough.js~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/transform.js~8d21794... deps: upgrade npm to 3.6.0'
error: Invalid path 'deps/npm/node_modules/readable-stream/writable.js~8d21794... deps: upgrade npm to 3.6.0'
Checking out files: 100% (16816/16816), done.

@janRucka
Copy link

The same issue for me when syncing chromium (for nw.js).

@mscdex mscdex mentioned this issue Feb 13, 2016
Closed
@pajoma
Copy link

pajoma commented Feb 13, 2016

Same issue here. Trying to use NPM in windows (through the Gradle plugin), but the build scripts fail due to the invalid file names in the tar.gz

@ChALkeR
Copy link
Member

ChALkeR commented Feb 16, 2016

/cc @nodejs/npm

mscdex added a commit to mscdex/io.js that referenced this issue Feb 17, 2016
@mscdex
deps: remove unnecessary files
cfbbb83 
This commit removes some unnecessary files introduced in 76cb81b
whose filenames are also not valid on Windows, causing problems when
checking out the repository on that platform.

Fixes: nodejs#5094
@kunalspathak kunalspathak mentioned this issue Feb 19, 2016
Closed
@joaocgreis joaocgreis mentioned this issue Feb 22, 2016
Closed
rvagg pushed a commit that referenced this issue Feb 23, 2016
@mscdex @rvagg
deps: remove unnecessary files
18c94e5 
This commit removes some unnecessary files introduced in 76cb81b
whose filenames are also not valid on Windows, causing problems when
checking out the repository on that platform.

Fixes: #5094
PR-URL: #5212
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@JoeDoyle23
Copy link
Member

It looks like this specific issue has been resolved. I was able to clone the repo and all of the files had proper names. Is there still a need for a broader fix in case this type of issue happens again?

@mscdex
Copy link
Contributor

mscdex commented Jul 9, 2016 •
edited
Loading

@JoeDoyle23 I believe nodejs/build#338 took care of this at the CI level so that such files are detected when compiling on the Windows CI nodes. This is done often enough (when testing PRs for example) that any files that slip through would get caught fairly quickly.

@mscdex mscdex closed this as completed Jul 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
npm Issues and PRs related to the npm client dependency or the npm registry. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@mscdex @pajoma @JoeDoyle23 @ChALkeR @kunalspathak @janRucka