Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build on Github Action test-macOS frequently fail due machine run out of disk space #3878

Closed
jakecastelli opened this issue Aug 30, 2024 · 5 comments
Closed

Build on Github Action test-macOS frequently fail due machine run out of disk space #3878

jakecastelli opened this issue Aug 30, 2024 · 5 comments
Labels
platform:osx

Comments

@jakecastelli
Copy link
Member

The Github Actions start to fail frequently on test-macOS build step due to the current build on mac is about 18GB which seems more than the allocated disk space on the runner (14GB limit IIRC). See this for a failure example:

test-macOS
You are running out of disk space. The runner will stop working when the machine runs out of disk space. Free space left: 47 MB

This currently impacts all the Pull Requests on nodejs cores.
@jakecastelli jakecastelli mentioned this issue Aug 30, 2024
Closed
@richardlau
Copy link
Member

GitHub only offers 14 GB of storage on their "standard" runners: https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

Unlike for Linux and Windows, GitHub do not offer more storage on their "large" (i.e. paid) runners (still 14 GB for macOS): https://docs.github.com/en/actions/using-github-hosted-runners/using-larger-runners/about-larger-runners#specifications-for-general-larger-runners

Apparently the amount of available disk space available decreased (albeit still with 14 GB available and therefore meeting GH's documented available storage) with GH's 20240827.4 macOS runner image -- there's a general discussion around this over in: actions/runner-images#10511

I'm aware of various hacks/scripts for the Ubuntu runners to reclaim space (see actions/runner-images#10386) but not for macOS.

I do not know if there is anything we can do to reduce the size of Node.js macOS builds -- they appear to be significantly larger than their Linux equivalents.

@targos
Copy link
Member

targos commented Aug 30, 2024

Should we disable macOS jobs for now?

@targos
Copy link
Member

targos commented Aug 30, 2024

The problem is that we would have 0 CI coverage for arm64 macOS if we do it (Jenkins CI currently only tests on x64)

@jakecastelli
Copy link
Member Author

Do we need Android sdk for macOS arm64 build? Any chance we can temporarily remove it (with a quick patch) from the test-macOS job? seems like it can claim back ~12GB storage space.

@jakecastelli jakecastelli mentioned this issue Aug 30, 2024
Merged
jakecastelli added a commit to jakecastelli/node that referenced this issue Aug 30, 2024
@jakecastelli
build: reclaim disk space on macOS GHA runner
f84b111 
Refs: nodejs/build#3878
nodejs-github-bot pushed a commit to nodejs/node that referenced this issue Aug 30, 2024
@jakecastelli
build: reclaim disk space on macOS GHA runner
d75e253 
Refs: nodejs/build#3878
PR-URL: #54658
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit to nodejs/node that referenced this issue Aug 30, 2024
@jakecastelli @RafaelGSS
build: reclaim disk space on macOS GHA runner
8c68d0d 
Refs: nodejs/build#3878
PR-URL: #54658
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit to nodejs/node that referenced this issue Aug 30, 2024
@jakecastelli @RafaelGSS
build: reclaim disk space on macOS GHA runner
625e10a 
Refs: nodejs/build#3878
PR-URL: #54658
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit to nodejs/node that referenced this issue Aug 30, 2024
@jakecastelli @RafaelGSS
build: reclaim disk space on macOS GHA runner
5443033 
Refs: nodejs/build#3878
PR-URL: #54658
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit to nodejs/node that referenced this issue Aug 31, 2024
@jakecastelli @RafaelGSS
build: reclaim disk space on macOS GHA runner
7dff19b 
Refs: nodejs/build#3878
PR-URL: #54658
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit to nodejs/node that referenced this issue Aug 31, 2024
@jakecastelli @RafaelGSS
build: reclaim disk space on macOS GHA runner
e9a76ae 
Refs: nodejs/build#3878
PR-URL: #54658
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
sendoru pushed a commit to sendoru/node that referenced this issue Sep 1, 2024
@jakecastelli @sendoru
build: reclaim disk space on macOS GHA runner
bb0c04b 
Refs: nodejs/build#3878
PR-URL: nodejs#54658
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit to nodejs/node that referenced this issue Sep 1, 2024
@jakecastelli @RafaelGSS
build: reclaim disk space on macOS GHA runner
6f0cf35 
Refs: nodejs/build#3878
PR-URL: #54658
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targos
Copy link
Member

targos commented Sep 1, 2024

Fixed by nodejs/node#54658

@targos targos closed this as completed Sep 1, 2024
@richardlau richardlau mentioned this issue Sep 5, 2024
Closed
@faulpeltz faulpeltz mentioned this issue Sep 10, 2024
Merged
UlisesGascon added a commit to nodesource/nsolid that referenced this issue Sep 12, 2024
@UlisesGascon
ci: reclaim disk space on macOS GHA runner
9e7264f 
- Ref: nodejs/node#54658
- Ref: nodejs/build#3878
@UlisesGascon UlisesGascon mentioned this issue Sep 12, 2024
Closed
UlisesGascon pushed a commit to nodesource/nsolid that referenced this issue Sep 13, 2024
@jakecastelli @UlisesGascon
build: reclaim disk space on macOS GHA runner
b840eed 
Refs: nodejs/build#3878
PR-URL: nodejs/node#54658
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@UlisesGascon UlisesGascon mentioned this issue Sep 13, 2024
Closed
@iwuliz iwuliz mentioned this issue Sep 20, 2024
Closed
targos pushed a commit to nodejs/node that referenced this issue Sep 22, 2024
@jakecastelli @targos
build: reclaim disk space on macOS GHA runner
762e17a 
Refs: nodejs/build#3878
PR-URL: #54658
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos pushed a commit to nodejs/node that referenced this issue Sep 26, 2024
@jakecastelli @targos
build: reclaim disk space on macOS GHA runner
ee6ace1 
Refs: nodejs/build#3878
PR-URL: #54658
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos pushed a commit to nodejs/node that referenced this issue Oct 2, 2024
@jakecastelli @targos
build: reclaim disk space on macOS GHA runner
71ca266 
Refs: nodejs/build#3878
PR-URL: #54658
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
santigimeno pushed a commit to nodesource/nsolid that referenced this issue Oct 10, 2024
@jakecastelli @santigimeno
build: reclaim disk space on macOS GHA runner
c542649 
Refs: nodejs/build#3878
PR-URL: nodejs/node#54658
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #182
Refs: nodejs/node#54658
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
louwers pushed a commit to louwers/node that referenced this issue Nov 2, 2024
@jakecastelli @louwers
build: reclaim disk space on macOS GHA runner
aae85ad 
Refs: nodejs/build#3878
PR-URL: nodejs#54658
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
tpoisseau pushed a commit to tpoisseau/node that referenced this issue Nov 21, 2024
@jakecastelli @tpoisseau
build: reclaim disk space on macOS GHA runner
0a98d30 
Refs: nodejs/build#3878
PR-URL: nodejs#54658
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
platform:osx
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@targos @richardlau @jakecastelli