Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/index.json reliability #94

Closed
springmeyer opened this issue May 6, 2015 · 2 comments · Fixed by #95
Closed

release/index.json reliability #94

springmeyer opened this issue May 6, 2015 · 2 comments · Fixed by #95

Comments

@springmeyer
Copy link

Yesterday https://iojs.org/download/release/index.json reported "modules":"44" for the v2.0.0 release which looks correct per https://github.com/iojs/io.js/blob/v2.0.0/src/node_version.h#L48.

But today the same endpoint reports 42. Any idea what changed? (I don't see any changes to https://github.com/iojs/build/commits/master/tools/dist/dist-indexer/ in the last day)

[
{"version":"v2.0.0","date":"2015-05-04","files":["linux-armv6l","linux-armv7l","linux-x64","linux-x86","osx-x64-pkg","osx-x64-tar","src","win-x64-exe","win-x64-msi","win-x86-exe","win-x86-msi"],"npm":"2.9.0","v8":"4.2.77.18","uv":"1.4.2","zlib":"1.2.8","openssl":"1.0.2a","modules":"42"},
....
]

I'm asking because for node-pre-gyp I need to get this number right. I can start parsing the node_versions.h header for all formal releases if release/index.js is not intended to be stable. But I'd sure love it to be stable. Let me know if there is something I can help with.

@rvagg
Copy link
Member

rvagg commented May 6, 2015

grr, a persistent bug that I apparently haven't squashed! something to do with the way dist-indexer caches values and how it handles lookup failures, I think. I'll remove the cache and run it again but that's not going to solve the bug obviously.

@springmeyer
Copy link
Author

Thanks, that fixed it! Also noticing it fixed the 1.1.x -> 1.8.x versions which were reporting 42 but should be reporting 43 (now fixed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants