-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: ubuntu 14.04 ppc64le #1075
Conversation
25cca3b
to
a2e04ce
Compare
If you have used this to configure ubuntu1404-ppc64_le-3 I think the next step is to connect it up to the so that we can validate the machine works as a test worker. The one thing we should probably test as part of that is the selection of the 4.9 versus 4.8 compiler. We should either have a script in the build repo for that or have that script isntalled as part of the ansible setup. It may make sense to be part of what is installed by the ansible scirpts as we'd need to update when we add support for a new compiler level which would also require ansible script updates. |
I have run the ansible script successfuly on ubuntu1404-ppc64_le-3. export CC=/usr/bin/gcc-4.8 |
I think next step is create test CI job as clone of existing job and do run against ubuntu1404-ppc64_le-3. I would like to check in a script into the build repo called something like set_gcc_level that would looks at the files checked out for Node.js (likely the version info) and then sets the required exports. The main downside is that we'd need a clone of the build repo but I don't think that would be a big deal. @nodejs/build any concerns? |
Checking scripts into the build repo is fine by me. https://github.com/nodejs/build/tree/master/jenkins/scripts has some prior work, if helpful at all. |
ping @jBarz |
@jBarz The paths don't seem to be quite right based on the ansible setup. I had to add the path to java 8 to get the jenkins agent to start: /home/iojs/jdk8u144-b01/jre/bin/java in jenkins.conf. jenkins.conf probably either needs to have the path updated like I did or probably better the path so that it include/home/iojs/jdk8u144-b01/jre/bins whatever the change it will need to be specific to ppcle |
Tests ran/passed for the 3 combinations. |
PR for script to select compiler level: #1103 that was tested in runs above on be-3. |
I modified the ansible script to append "/home/iojs/.profile" with Is this an acceptable solution? |
@maclover7 can you review/approve #1103 as its related to this work. |
@mhdawson Approved 1103. Once this is ready, please feel free to land in master, and then please run on all PPC machines to confirm everything's OK. |
Unfortunately the change to set the path does not quite work as the script that starts the worker sets the path directly. Will discuss with @jBarz to figure out how to fix. |
3570961
to
e062922
Compare
Looks good with latest update from @jBarz |
PR-URL: #1075 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Landed as 443f72e |
Enable ubuntu 14.04 ppc64le.
Have both gcc 4.8 and 4.9 on machine available