-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jenkins: add node-test-commit-v8-linux script #1344
Conversation
Should be enough to run |
9a03fa2
to
6916a66
Compare
@mmarchini the build phase of the job should be similar to a regular |
Yes |
So this is our build script #!/bin/bash -xe
FLAKY_TESTS_MODE=run
if test $IGNORE_FLAKY_TESTS = "true"; then
FLAKY_TESTS_MODE=dontcare
fi
echo FLAKY_TESTS_MODE=$FLAKY_TESTS_MODE
if [ -z ${JOBS+x} ]; then
export JOBS=$(getconf _NPROCESSORS_ONLN)
fi
MAKE_ARGS="-j $JOBS"
if [ $(make -v | grep 'GNU Make 4' -c) -ne 0 ]; then
MAKE_ARGS="$MAKE_ARGS --output-sync=target"
fi
exec_cmd=" \
NODE_TEST_DIR=${HOME}/node-tmp \
PYTHON=python \
FLAKY_TESTS=$FLAKY_TESTS_MODE \
make run-ci $MAKE_ARGS \
"
if test $nodes = "centos6-64-gcc48"; then
exec_cmd=". /opt/rh/devtoolset-2/enable; $exec_cmd"
elif [[ "$nodes" =~ centos[67]-(arm)?64-gcc6 ]]; then
exec_cmd=". /opt/rh/devtoolset-6/enable; $exec_cmd"
fi
echo $exec_cmd
V=1
$SHELL -xec "$exec_cmd" I'm sure there is a ton of cross platform unneeded code there, but the tl;dr is we run |
Since there's no need to run all tests, is diff --git a/jenkins/scripts/node-test-v8-updates.sh b/jenkins/scripts/node-test-v8-updates.sh
index 487d569..72da7aa 100755
--- a/jenkins/scripts/node-test-v8-updates.sh
+++ b/jenkins/scripts/node-test-v8-updates.sh
@@ -11,7 +11,4 @@ git clone https://github.com/nodejs/build.git
. ./build/jenkins/scripts/node-test-commit-pre.sh
-./configure;
-make -j $(getconf NPROCESSORS_ONLN);
-
-python tools/test.py -p tap --logfile test.tap --mode=release v8-updates
+make run-ci CI_JS_SUITES="v8-updates" CI_NATIVE_SUITES="" CI_DOC="" |
I'm tryin to think of the smoothest way to add this job since |
@mmarchini I created a new job and given you edit perms: https://ci.nodejs.org/job/node-test-commit-linux-v8-updates/configure |
Worked 😄
|
@mmarchini Ahh, didn't fully understand what was needed here. In theory, you should just be able to utilize |
@maclover7 thanks for pointing this out, but |
I added |
@mmarchini Ah true -- let me update that job configuration, and then we should be okay to use that (would rather try and reuse existing job pieces if possible than introduce new stuff, to avoid more complexity in Jenkins) |
Well that gives weird results, every platform job triggers a Let me do some key mashing... 🤔 |
@mklebrasseur do you have a quick answer for this? tl;dr: |
@refack sure I can have a look. Do I need any additional access for those jobs to view the build steps. I am rather new to this project and have not got my grounds yet. |
Unfortunately, Yes... If you know how to enable "read only" view, that's also interesting. Best I can do is a screenshot and the XML ATM I added the sub job as the last post-build-action. |
Ok, thanks, At first glance could use "when" to decide when to run it or not. I will review further and follow up. Thanks for the invite on the review :). |
🔔 🔔 🔔 |
Yea, my mistake I was looking at the repo before with the use of some pipelines. I've never enjoyed having to use the UI to build out any builds. Shared libraries I found to be much easier and allow for granular access using git (as well as read only). We recently converted all our legacy builds to pipelines this month. It's very fresh in my head. Conditional will work fine, also the use of a shared library would work too. Apologies for the delayed response. |
@mklebrasseur and @mmarchini I gave you read access to https://ci.nodejs.org/job/node-test-commit-v8-linux/configure |
@refack yes I can confirm that can see the configuration. No save options appear (y) |
This comment has been minimized.
This comment has been minimized.
Relevant Jenkins log:
https://ci.nodejs.org/job/node-test-commit-custom-suites/17/ |
Wonder if you should use Regexp instead of Strings |
I should have verified that https://ci.nodejs.org/job/node-test-commit-custom-suites/20/ seems to be working. |
Worked this time 😄 It's not very intuitive to see the test result (node-test-commit-v8-linux#1439 > nodes=benchmark > node-test-commit-custom-suites#21), but we can improve that in the future if we think it's necessary. |
Ref: #1342
Ref: nodejs/node#20783