Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: tweak macOS PATH #1511

Merged
merged 1 commit into from
Sep 29, 2018
Merged

ansible: tweak macOS PATH #1511

merged 1 commit into from
Sep 29, 2018

Conversation

refack
Copy link
Contributor

@refack refack commented Sep 27, 2018

  • Specify PATH explicitly so that it matches the environment
    when SSHing and running sudo su iojs

* Specify PATH explicitly so that it matches the environment
  when SSHing and running `sudo su iojs`
@refack
Copy link
Contributor Author

refack commented Sep 27, 2018

Otherwise there's a mess with where python is and how to pip install stuff to it.

gdams

This comment was marked as off-topic.

@refack refack merged commit 7ef54f4 into nodejs:master Sep 29, 2018
@refack refack deleted the tweak-macos-path branch September 29, 2018 20:26
@gdams
Copy link
Member

gdams commented Sep 30, 2018

As a future note, we might be able to make use of the built in pathhelper tool /usr/libexec/path_helper -s to generate the PATH for us rather than having to hard code it.

@refack
Copy link
Contributor Author

refack commented Sep 30, 2018

generate the PATH for us rather than having to hard code it.

There is some convenience in having the PATH static and explicit... As long as we don't need to change it too often...
(Some discussion about C++ auto made me think about explicit vs. implicit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants