Updates for jenkins-workspace binary temporaries repository #1515
Conversation
This is necessary when many workers running tests try to access the temp repo to download binaries simultaneously.
|
Question: any reason not to use Jenkins' built-in cron (just so that we don't have configuration in too many places)? |
|
@refack was there before, I removed it because the job is broken. Deleting the job and archiving as XML here is the next step there. |
| fi | ||
| done | ||
|
|
||
| git prune |
There was a problem hiding this comment.
maybe add a nohup git gc >& ~binary_tmp/git_gc_`date +"%s"`.log ?
That way we won't get an auto gc in the middle of a future fetch
There was a problem hiding this comment.
Please see below about gc.
| git fetch origin +master:master | ||
|
|
||
| for b in $(git branch | sed /\*/d); do | ||
| if [ -z "$(git log -1 --since='4 weeks ago' -s $b)" ]; then |
There was a problem hiding this comment.
| if [ -z "$(git log -1 --since='4 weeks ago' -s $b)" ]; then | |
| if [ -z "$(git log -1 --since='5 days ago' -s $b)" ]; then |
IMO 5 days is enough. After five days we should run a rebuild not a resume (since master probably progressed).
There was a problem hiding this comment.
agreed, 4 weeks is a long time, any good reason for that @joaocgreis?
There was a problem hiding this comment.
I find that after a week the jobs are most often no longer in the history anyway. Maybe 7 days?
There was a problem hiding this comment.
7 days sounds reasonable, updated.
This job no longer works because Jenkins requires a token. Replaced by: nodejs#1515
|
Updated (9b6f4b0), PTAL.
|
This is necessary when many workers running tests try to access the temp repo to download binaries simultaneously. PR-URL: #1515 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
PR-URL: #1515 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
|
Landed in a1957ef...5961359 |
This does two things:
sshd_config. This is necessary when many workers running tests try to access the temp repo to download binaries simultaneously. Not sure if there is an optimal value for this. Since the previous value seemed to just barely not be enough, I increased it 10x considering it is possible that more than one job might be started at the same time.git-clean-temp-repo, which was broken not only because of this but also because unauthenticated access to Jenkins is disabled.