smartos: use Google DNS servers #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @nodejs/build |
|
rubber-stamp lgtm but I'd like to see input from @jbergstroem if he has time |
|
LGTM |
1 similar comment
|
LGTM |
DNS tests are sensible to which DNS servers are used. Google DNS servers are known to work and should provide a stable DNS environment to run the tests. Fixes: nodejs/node-v0.x-archive#25858 Fixes: nodejs#155 PR-URL: nodejs#156 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
joaocgreis
force-pushed
the
joaocgreis-F8H-smartos-dns
branch
from
e9e50b6 to
18b3608
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen recently in nodejs/node-v0.x-archive#25858 , DNS configuration is sensitive for the tests. The test machines should be configured to use Google DNS servers, and using other servers may cause tests to fail, as discussed in nodejs/node-v0.x-archive#8056 .
I changed the DNS configuration in the SmartOS slaves by editing
/etc/resolv.conf. This PR makes this change permanent by adding it to the ansible playbook.Fixes: nodejs/node-v0.x-archive#25858
Fixes: #155