-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use devtoolset-6 for s390x on node gt 11.x #1754
Conversation
devtoolset-6 is authorized for use on IBM systems (and the s390x boxes are IBM systems) for the purposes Node.js would use it for, but installing it requires downloading RPMs through an authenticated portal. I don't see how this can be ansibled, so I created /data/devtoolset-6-s390x-rpms/ on the 3 s390x boxes. I installed it on only -3, using /to @mhdawson |
It appears to me that devtoolset does indeed build more portable binaries, even with no additional configuration. See:
|
We might want to leave this PR with the selection being gcc6, until we get the ansible changes in to help install the dev toolset as well? EDIT: Nevermind, my confusion. There is a separate PR for gcc6 and this one is focused on the dev toolset. |
We've discussed this approach for the dev toolset. Store the rpms on one of the s390 machines and then have ansible pull/install from there when it is run. This is because we believe the licence allows them to be on IBM machines (which the ones in the community are) but not otherwise redistributed. This approach is not perfect but a step better than simply manually installing on all machines. |
NODE_NAME is not defined when not running with jenkins, so anyone trying to do builds directly has to read the script and deduce that NODE_NAME has to be set, and to what it has to be set, or the script will silently do nothing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Landed as cf02bff |
Depends on #1755