Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow: add stale action #2196

Merged
merged 1 commit into from
Mar 4, 2020
Merged

workflow: add stale action #2196

merged 1 commit into from
Mar 4, 2020

Conversation

sam-github
Copy link
Contributor

Setup to mark stale after 90 days, and close 15 days after marked stale
unless the issue is commented on, or has the stale label removed.

Fixes: #2190


Draft - awaiting some comment on #2190 to agree this is useful. I've never configured a GH action before, I'd appreciate a review by someone who has!

@rvagg
Copy link
Member

rvagg commented Feb 25, 2020

I can't muster a strong opinion on this tbh, the open issues don't bother me so much on this repo since we're not so much building code (where open issues and prs bother me more) but managing infra (where status and information is more useful). If you think this will add value then I'm fine with working around it where it gets in my way, being able to label and/or bump is easy enough.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented Mar 3, 2020

No objections from those who were at the build WG meeting this week. We should move forward with it.

@richardlau
Copy link
Member

Do we want an exempt-issue-label?

@AshCripps
Copy link
Member

Do we want an exempt-issue-label?

I think its a good idea as some issues can be open for a long time for a reason (waiting on people time to free up, etc)

@sam-github sam-github marked this pull request as ready for review March 4, 2020 20:08
Setup to mark stale after 300 days, and close 30 days after marked stale
unless the issue is commented on, or has the `stale` label removed.

The 'never stale' label can be used to exempt an issue from ever being
considered stale.

Fixes: #2190
@sam-github sam-github merged commit f4721d1 into nodejs:master Mar 4, 2020
@sam-github sam-github deleted the add-stale-action branch March 4, 2020 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suggestion: we enable the "stale" bot on nodejs/build
5 participants