Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins: select gcc12 on AIX for Node.js >=23 #3858

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

richardlau
Copy link
Member

Refs: #3806
Refs: #3773

@richardlau
Copy link
Member Author

richardlau commented Aug 8, 2024

Test CI: https://ci.nodejs.org/job/richardlau-node-test-commit-aix/65/ ✔️

+ . ./build/jenkins/scripts/select-compiler.sh
++ '[' '' '!=' DONT ']'
++ NODE_NAME=test-ibm-aix72-ppc64_be-1
++ echo 'Selecting compiler based on test-ibm-aix72-ppc64_be-1'
Selecting compiler based on test-ibm-aix72-ppc64_be-1
++ case $NODE_NAME in
++ SELECT_ARCH=AIXPPC
++ '[' -z x ']'
++ case $NODE_NAME in
++ '[' AIXPPC = PPC64LE ']'
++ '[' AIXPPC = S390X ']'
++ '[' AIXPPC = IBMI73 ']'
++ '[' AIXPPC = AIXPPC ']'
++ '[' 23 -gt 22 ']'
++ export COMPILER_LEVEL=12
++ COMPILER_LEVEL=12
+++ oslevel
++ export AIX_VERSION=7.2.0.0
++ AIX_VERSION=7.2.0.0
++ echo 'Setting compiler for Node version 23 on AIX 7.2.0.0'
Setting compiler for Node version 23 on AIX 7.2.0.0
++ export CC=gcc-12
++ CC=gcc-12
++ export CXX=g++-12
++ CXX=g++-12
++ export LINK=g++-12
++ LINK=g++-12
++ '[' 12 -ne 10 ']'
++ export LIBPATH=/opt/freeware/lib/gcc/powerpc-ibm-aix7.2.0.0/12/pthread:/opt/freeware/lib:/usr/lib:/lib
++ LIBPATH=/opt/freeware/lib/gcc/powerpc-ibm-aix7.2.0.0/12/pthread:/opt/freeware/lib:/usr/lib:/lib
++ export PATH=/opt/ccache-3.7.4/libexec:/opt/freeware/bin:/opt/freeware/bin:/usr/opt/python3/bin/:/usr/bin:/etc:/usr/sbin:/usr/ucb:/home/iojs/bin:/usr/bin/X11:/sbin:.
++ PATH=/opt/ccache-3.7.4/libexec:/opt/freeware/bin:/opt/freeware/bin:/usr/opt/python3/bin/:/usr/bin:/etc:/usr/sbin:/usr/ucb:/home/iojs/bin:/usr/bin/X11:/sbin:.
+++ g++-12 -dumpversion
++ echo 'Compiler set to GCC' 12
Compiler set to GCC 12
+ curl -s https://raw.githubusercontent.com/nodejs/node/main/CHANGELOG.md
+ PYTHONUTF8=1
+ NODE_TEST_DIR=/home/iojs/build
+ TMP=/home/iojs/build
+ FLAKY_TESTS=dontcare
+ CONFIG_FLAGS=' --dest-cpu=ppc64'
+ gmake run-ci -j 8 JOBS=8
python3 ./configure --verbose  --dest-cpu=ppc64
Node.js configure: Found Python 3.9.19...
Detected C++ compiler (CXX=g++-12) version: 12.3.0
Detected C compiler (CC=gcc-12) version: 12.3.0
...

Copy link
Contributor

@abmusse abmusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau merged commit 065a002 into nodejs:main Aug 15, 2024
2 checks passed
@richardlau richardlau deleted the aixselectgcc12 branch August 15, 2024 12:21
@richardlau richardlau restored the aixselectgcc12 branch August 15, 2024 12:22
nodejs-github-bot pushed a commit to nodejs/node that referenced this pull request Aug 16, 2024
Use gcc 12 to build the official binaries for Node.js 23 onwards on
AIX. Note that this will require `libstdc++12`, available from the
AIX toolbox.

PR-URL: #54338
Refs: nodejs/build#3806
Refs: nodejs/build#3858
Refs: #54081
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants