jenkins: improve x64 node.exe caching for arm64 #3965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies caching by removing the downloading step. The x64 node.exe is now expected to be already cached before running compile.cmd. The same change was already applied successfully to the release CI. Refs: nodejs#3315
richardlau
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 3rd, and hopefully the last attempt at solving x64 node.exe caching in the CI needed to generate license files when compiling for ARM64. Compared to the previous 2, this one simplifies caching by removing the downloading step. The x64 node.exe is now expected to be already cached before running compile.cmd.
The same change was already applied successfully to the release CI.
Refs: #3315
Refs: #3514
Refs: #3533
Refs: #3842
Refs: #3849