Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop escaping markdown characters inside code blocks #58

Open
XhmikosR opened this issue Sep 26, 2019 · 6 comments
Open

Stop escaping markdown characters inside code blocks #58

XhmikosR opened this issue Sep 26, 2019 · 6 comments

Comments

@XhmikosR
Copy link
Contributor

nodejs/nodejs.org#2608 (comment)

@BridgeAR
Copy link
Member

@XhmikosR would you be fine to open a PR to fix this? I think that would be ideal :-)

@XhmikosR
Copy link
Contributor Author

It's tricky so I was hoping someone else could tackle this :)

Otherwise I'll try to find a solution.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Sep 26, 2019

I've come up with this but I'm not sure if it's the best solution...

https://regex101.com/r/t90Tqw/2

@Trott
Copy link
Member

Trott commented Sep 27, 2019

I suspect a regexp will never be 100% reliable, but it can probably be sufficiently reliable. 100% reliability would probably require doing proper parsing instead of regexp matching.

@XhmikosR
Copy link
Contributor Author

I don't think my regex is good. I'll see if I can improve it and make a PR.

@XhmikosR
Copy link
Contributor Author

Unfortunately, the project doesn't work on Windows, so I can't do a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants