v12.12.0 proposal #29919
Merged
v12.12.0 proposal #29919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: v8/v8@7.7.299.11...7.7.299.13 PR-URL: #29869 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
PR-URL: #29631 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: #29631 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Add `privateKeyIdentifier` and `privateKeyEngine` options to get private key from an OpenSSL engine in tls.createSecureContext(). PR-URL: #28973 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
PR-URL: #29705 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #29716 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
The TSC has responsibility for Node.js security, so avoid fragmentation of the Node.js maintenance process documentation by adding it to the other guides. PR-URL: #29685 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This updates all sources in deps/openssl/openssl by:
$ cd deps/openssl/
$ rm -rf openssl
$ tar zxf ~/tmp/openssl-1.1.0h.tar.gz
$ mv openssl-1.1.0h openssl
$ git add --all openssl
$ git commit openssl
PR-URL: #29550
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
After an OpenSSL source update, all the config files need to be
regenerated and comitted by:
$ cd deps/openssl/config
$ make
$ git add deps/openssl/config/archs
$ git add deps/openssl/openssl/crypto/include/internal/bn_conf.h
$ git add deps/openssl/openssl/crypto/include/internal/dso_conf.h
$ git add deps/openssl/openssl/include/openssl/opensslconf.h
$ git commit
PR-URL: #29550
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
OpenSSL 1.1.1d no longer generates warnings for some DH groups that used to be considered unsafe. See below for discussion. This is considered a bug fix. See: - openssl/openssl#9363 - openssl/openssl#9363 (comment) PR-URL: #29550 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This is just a refactoring to reduce code and computational overhead. PR-URL: #29683 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #29772 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
The library is not necessary for ppc64 or s390x. It does no harm with some linkers, but devtoolset-6 creates runtime dependencies on all link libraries, even unused ones. Fixes: #27377 Fixes: #29718 PR-URL: #29727 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #29727 Fixes: #27377 Fixes: #29718 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* Make a section with a history remark a YAML section of the relevant method. Refs: #29761 (comment) * Make a bold line a real heading to be included in the TOC. * Add formal return types. * Reduce redundancy in a description. * Unify link format. * Fix ASCII sorting in bottom references. PR-URL: #29761 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Refs: #29725 (comment) PR-URL: #29769 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #29558 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #29558 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reference links were used in the document, but not define at the end. PR-URL: #29558 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
It gets confused as a reference link otherwis PR-URL: #29558 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This change also supports --pending-deprecation for the new deprecation. PR-URL: #29781 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Fixes: #29764 PR-URL: #29780 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
- Removes redundant `instantiate` method - Refactors `link` to match the spec linking steps more accurately - Removes URL validation from SourceTextModule specifiers - DRYs some dynamic import logic Closes: #29030 Co-Authored-By: Michaël Zasso <targos@protonmail.com> PR-URL: #29776 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Remove reference to job that is out of date, has not been run for a long time and likely does not work properly. Refs: nodejs/citgm#741 PR-URL: #29774 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #29777 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #29820 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
PR-URL: #29785 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: David Carlier <devnexen@gmail.com>
PR-URL: #29746 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This improves Node.js errors by always showing the attached properties when inspecting such an error. This applies especially to SystemError. It did often not show any properties but now all properties will be visible. This is done in a mainly backwards compatible way. Instead of using prototype getters and setters, the property is now set directly on the error. PR-URL: #29677 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Since 71f633a, this is no longer necessary. Refs: #22622 Fixes: #29793 PR-URL: #29795 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
|
@nodejs/releasers PTAL |
|
@XhmikosR PTAL. I would like to be sure that the changelog does not contain any escape sequences again that cause problems with the website. |
|
@BridgeAR LGTM. We really need to move forward with https://github.com/nodejs/changelog-maker/pulls so that we can improve the regex to ignore the special characters if they are inside backticks. |
|
Anyone have any insights into the failing === release test-zlib-unused-weak ===
Path: parallel/test-zlib-unused-weak
--- stderr ---
assert.js:374
throw err;
^
AssertionError [ERR_ASSERTION]: Expected after-GC delta 474434 to be less than 5 % of before-GC delta 1613656
at Object.<anonymous> (/home/travis/build/nodejs/node/test/parallel/test-zlib-unused-weak.js:16:1)
at Module._compile (internal/modules/cjs/loader.js:956:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:973:10)
at Module.load (internal/modules/cjs/loader.js:812:32)
at Function.Module._load (internal/modules/cjs/loader.js:724:14)
at Function.Module.runMain (internal/modules/cjs/loader.js:1025:10)
at internal/main/run_main_module.js:17:11 {
generatedMessage: false,
code: 'ERR_ASSERTION',
actual: false,
expected: true,
operator: '=='
}
Command: out/Release/node --expose-gc /home/travis/build/nodejs/node/test/parallel/test-zlib-unused-weak.js |
|
I am also not sure if I can't remember any of these failures before. The socket-io error looks like a flake to me (https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2046/nodes=osx1011/testReport/junit/(root)/citgm/socket_io_v2_3_0/). @richardlau the error seems to only occur in containerised infrastructure. Let's see a CI for v12.11.1: https://ci.nodejs.org/job/node-test-commit/31815/ |
Ember CLI fails occasionally in CITGM. See, for example, #29504 (comment) and #29504 (comment). If you just see one or maybe two failures, I wouldn't worry about it. If you see more than that, that warrants closer examination. |
|
I guess it's a flaky test, since the resumed CI passed. @nodejs/releasers @nodejs/tsc are you fine with pushing out the release or should we further investigate the mentioned test failure? |
|
It is getting late and I guess there won't be a decision about pushing the release as is soon. So let's postpone it until tomorrow. |
|
I think we can consider the test failure a flake. I see no change in zlib or src that could affect this and the test relies on GC behavior that are not really under our control. |
targos
approved these changes
Oct 11, 2019
BethGriggs
approved these changes
Oct 11, 2019
Notable changes:
* build:
* Add `--force-context-aware` flag to prevent usage of native node
addons that aren't context aware
#29631
* deprecations:
* Add documentation-only deprecation for `process._tickCallback()`
#29781
* esm:
* Using JSON modules is experimental again
#29754
* fs:
* Introduce `opendir()` and `fs.Dir` to iterate through directories
#29349
* process:
* Add source-map support to stack traces by using
`--source-map-support` #29564
* tls:
* Honor `pauseOnConnect` option
#29635
* Add option for private keys for OpenSSL engines
#28973
PR-URL: #29919
BridgeAR
force-pushed
the
v12.12.0-proposal
branch
from
75baa7e to
921493e
Compare
BridgeAR
added a commit
that referenced
this pull request
Oct 11, 2019
Notable changes:
* build:
* Add `--force-context-aware` flag to prevent usage of native node
addons that aren't context aware
#29631
* deprecations:
* Add documentation-only deprecation for `process._tickCallback()`
#29781
* esm:
* Using JSON modules is experimental again
#29754
* fs:
* Introduce `opendir()` and `fs.Dir` to iterate through directories
#29349
* process:
* Add source-map support to stack traces by using
`--source-map-support` #29564
* tls:
* Honor `pauseOnConnect` option
#29635
* Add option for private keys for OpenSSL engines
#28973
PR-URL: #29919
|
It will take a bit longer until I publish the release with the release builds, since I just got back a bit earlier to my notebook and the release builds had to be run again due to the changed release date. |
BridgeAR
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Oct 11, 2019
BridgeAR
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Oct 11, 2019
targos
added
release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes
--force-context-awareflag to prevent usage of native node addons that aren't context aware #29631process._tickCallback()#29781opendir()andfs.Dirto iterate through directories #29349--source-map-support#29564pauseOnConnectoption #29635Commits
d09f2b4170] - build: build docs on Travis (Richard Lau) #2978303ec4cea30] - build: do not link against librt on linux (Sam Roberts) #29727f91778d2c7] - build: remove unused libatomic on ppc64, s390x (Sam Roberts) #29727ab4c53e0ef] - crypto: remove arbitrary UTF16 restriction (Anna Henningsen) #2979575f3b28d67] - crypto: refactor array buffer view validation (Ruben Bridgewater) #296835eb013b854] - deps: update archs files for OpenSSL-1.1.1 (Sam Roberts) #295501766cfcb9e] - deps: upgrade openssl sources to 1.1.1d (Sam Roberts) #295503d88b76680] - deps: patch V8 to 7.7.299.13 (Michaël Zasso) #29869600478ac13] - dgram: useuv_udp_try_send()(Anna Henningsen) #29832ea6b6abb91] - doc: remove spaces inside code span elements (Nick Schonning) #2932920b9ef92d1] - doc: add more info to fs.Dir and fix typos (Jeremiah Senkpiel) #29890f566cd5801] - doc: remove misleading paragraph about the Legacy URL API (Jakob Krigovsky) #29844a5c2154534] - doc: add explicit bracket for markdown reference links (Nick Schonning) #29808ea9bf4a666] - doc: implement minor CSS improvements (XhmikosR) #29669a0498606a0] - doc: fix return type for crypto.createDiffieHellmanGroup() (exoego) #29696a00cd17b9e] - doc: reuse link indexes for n-api.md (legendecas) #29787aea0253697] - doc: unify place of stability notes (Vse Mozhet Byt) #297998b4f210bf5] - doc: add missing deprecation code (cjihrig) #29820bede98128f] - doc: remove reference to stale CITGM job (Michael Dawson) #29774014eb67117] - (SEMVER-MINOR) doc: add documentation deprecation for process._tickCallback (Lucas Holmquist) #2978162370efe7e] - doc: add dash between SHA and PR in changelog (Nick Schonning) #29558d1a4aa3ca2] - doc: add missing reference link values (Nick Schonning) #29558de4652f55e] - doc: convert old changlogs SHA links to match newer format (Nick Schonning) #2955860b1f6f303] - doc: complete cut off links in old changelog (Nick Schonning) #29558906245e1a4] - doc: clarify --pending-deprecation effects on Buffer() usage (Rich Trott) #29769401f3e7235] - doc: fix nits in dgram.md (Vse Mozhet Byt) #29761bc48646206] - doc: improve process.ppid 'added in' info (Thomas Watson) #297720b46bcaaa5] - doc: security maintenance processes (Sam Roberts) #29685f39259c079] - doc: remove redundant escape (XhmikosR) #2971687fb1c297a] - errors: make sure all Node.js errors show their properties (Ruben Bridgewater) #29677df218ce066] - Revert "esm: remove experimental status from JSON modules" (Guy Bedford) #29754e7f604f495] - esm: remove proxy for builtin exports (Bradley Farias) #29737c56f765cf6] - fs: remove options.encoding from Dir.read*() (Jeremiah Senkpiel) #29908b76a2e502c] - (SEMVER-MINOR) fs: introduceopendir()andfs.Dir(Jeremiah Senkpiel) #293492bcde8309c] - (SEMVER-MINOR) http2: allow passing FileHandle to respondWithFD (Anna Henningsen) #29876a240d45d1a] - http2: support passing options of http2.connect to net.connect (ZYSzys) #298163f153789b5] - http2: set default maxConcurrentStreams (ZYSzys) #298336a989da6a0] - http2: use the latest settings (ZYSzys) #29780b2cce13235] - inspector: update faviconUrl (dokugo) #2956260296a3612] - lib: make tick processor detect xcodebuild errors (Ben Noordhuis) #298309e5d691ee4] - lib: introduce no-mixed-operators eslint rule to lib (ZYSzys) #2983474a69abd12] - lib: stop using prepareStackTrace (Gus Caplan) #2977790562ae356] - module: use v8 synthetic modules (Guy Bedford) #2984620896f74d6] - n-api,doc: clarify napi_finalize related APIs (legendecas) #2979765c475269e] - net: emit close on unconnected socket (Robert Nagy) #29803ae8b2b4ab7] - (SEMVER-MINOR) process: add source-map support to stack traces (bcoe) #295643f6ce39acf] - src: fix ESM path resolution on Windows (Thomas) #295746bfe8f47fa] - (SEMVER-MINOR) src: add buildflag to force context-aware addons (Shelley Vohr) #296316c75cc1b11] - stream: do not deadlock duplexpair (Robert Nagy) #29836320f649539] - stream: add comment about undocumented API (Robert Nagy) #298055fdf4a474f] - test: remove extra process.exit() (cjihrig) #298736a5d401f30] - test: remove spaces inside code span elements (Nick Schonning) #29329adee99883a] - test: debug output for dlopen-ping-pong test (Sam Roberts) #29818b309e20661] - test: add test for HTTP server response with Connection: close (Austin Wright) #29836bf1727a3f3] - test: add test for writable.write() argument types (Robert Nagy) #297463153dd6766] - test: well-defined DH groups now verify clean (Sam Roberts) #29550690a863aaa] - test: simplify force-context-aware test (cjihrig) #2970554ef0fd010] - (SEMVER-MINOR) test: --force-context-aware cli flag (Shelley Vohr) #29631a7b56a5b01] - (SEMVER-MINOR) tls: honor pauseOnConnect option (Robert Jensen) #29635cf7b4056ca] - (SEMVER-MINOR) tls: add option for private keys for OpenSSL engines (Anton Gerasimov) #28973ba4946a520] - tools: prohibit Error.prepareStackTrace() usage (Ruben Bridgewater) #2982779f6cd3606] - tools: update ESLint to v6.5.1 (Rich Trott) #297856d88f0fef7] - vm: refactor SourceTextModule (Gus Caplan) #29776a7113048e3] - worker: do not use two-arg NewIsolate (Shelley Vohr) #29850