Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip AIX in undici, as esbuild does not run there #1068

Closed
wants to merge 1 commit into from

Conversation

mcollina
Copy link
Member

No description provided.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@richardlau
Copy link
Member

Skip AIX in undici, as esbuild does not run there

It should do, as of esbuild@0.19.10 (evanw/esbuild#3549).

@merceyz
Copy link
Member

merceyz commented Jul 22, 2024

And if that doesn't work, Undici could try using esbuild-wasm instead.

@mcollina
Copy link
Member Author

@richardlau
Copy link
Member

Well, this failed: https://ci.nodejs.org/job/citgm-smoker/3465/nodes=aix72-ppc64/testReport/junit/(root)/citgm/undici_v6_19_2/.

It's using an older esbuild (i.e. less than 0.19.10).

 > npx esbuild@0.19.4 index-fetch.js --bundle --platform=node --outfile=undici-fetch.js --define:esbuildDetection=1 --keep-names && node scripts/strip-comments.js

@mcollina
Copy link
Member Author

Ah! Will update.

@mcollina mcollina closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants