package: upgrade dependencies #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did not upgrade to `winston` 3 here because it has big breaking changes. Summary of semver-major changes: - strip-ansi: - drops Node 4 - yargs: - drops Node 4 - whitespace changes in help output - Options absent from argv (not set via CLI argument) are now absent from the parsed result object rather than being set with undefined - eslint: - drops Node 4 - new rules in eslint:recommended - some default options in rules changed - tap - Breaking change to support deep matching and pattern matching of objects in Set collections
|
@nodejs/citgm |
3 tasks
|
Failures are unrelated. I opened nodejs/build#1548 and nodejs/build#1549 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not upgrade to
winston3 here because it has big breaking changes.Summary of semver-major changes:
strip-ansi:
yargs:
eslint:
tap
npm testpassescontribution guidelines followed here