lookup: skip stylus, shot, bluebird and sqlite3 on Node 11

[targos]

They fail everywhere. See https://ci.nodejs.org/job/citgm-smoker/1602

[targos]

@nodejs/citgm

[mcollina]

I wonder how this was not noticed during development.

Can you open issues in the various repos? Those are pretty popular libraries that should be updated.

[mcollina]

I'll fix shot.

[MylesBorins]

bluebird has been fixed upstream

petkaantonov/bluebird#1560

taking a look at sqlite3

[mcollina]

After a more close examination, fixing shot is not straighforward, as the testing library that they are using, lab is on an outdated version whose tests do not pass on Node 11.

Updating the library fixes it: hapijs/shot#99

[mcollina]

shot should be fixed!

[targos]

thanks @mcollina !

For bluebird, we need a new release. /cc @benjamingr

[targos]

For sqlite3, I can only reproduce with citgm sqlite3. If I download the tarball that citgm used, npm i, npm test, everything is fine.

[targos]

The error is:

warn:                        | sed: can't read ./Release/.deps/Release/obj.target/sqlite3/gen/sqlite-autoconf-3240000/sqlite3.o.d.raw: No such file or directory
warn:                        | rm: cannot remove './Release/.deps/Release/obj.target/sqlite3/gen/sqlite-autoconf-3240000/sqlite3.o.d.raw': No such file or directory
warn:                        | make: *** [deps/sqlite3.target.mk:129: Release/obj.target/sqlite3/gen/sqlite-autoconf-3240000/sqlite3.o] Error 1

[benjamingr]

For bluebird, we need a new release. /cc @benjamingr

On it. Will take a few days as Petka has they keys and I need to get a hold of him.

[targos]

Stylus is fixed on the dev branch. There was just no release since 2016.

[mcollina]

Are they planning to issue one? Il giorno sab 3 nov 2018 alle 12:20 Michaël Zasso <notifications@github.com> ha scritto:

…

Stylus is fixed on the dev branch. There was just no release since 2016. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#616 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADL46rqo15s9FHjRbshK__TwvFTJzNLks5urXvkgaJpZM4X-Aoa> .

[targos]

@mcollina I don't know that.

[benjamingr]

@targos bluebird did a release with @MylesBorins's pr fixing this issue in yesterday.

[targos]

@benjamingr thanks. I confirm citgm bluebird now passes on Node 11

[targos]

bluebird and shot are fixed and I cannot reproduce the sqlite3 failure anymore. I will probably reopen another PR to skip only stylus.