Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: add eslint-plugin-jest #686

Merged
merged 3 commits into from
Mar 17, 2019
Merged

lookup: add eslint-plugin-jest #686

merged 3 commits into from
Mar 17, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Mar 13, 2019

This is mostly to have a code base using Jest. It would be preferable to include Jest itself instead, but that is currently difficult due to some issues around colors.

See #684.

$ node -v
v12.0.0-nightly20190313e6fa50e953
$ node bin/citgm.js eslint-plugin-jest
info:    starting            | eslint-plugin-jest
warn:    update-available    | v4.0.0 (current: v3.4.8)
warn:                        | npm install -g citgm
info:    lookup              | eslint-plugin-jest
info:    lookup-found        | eslint-plugin-jest
info:    eslint-plugin-jest lookup-replace| https://github.com/jest-community/eslint-plugin-jest/archive/f6f6d84c1134bc3d1aff9c2715e97d309e185bc3.tar.gz
info:    eslint-plugin-jest npm:| Downloading project: https://github.com/jest-community/eslint-plugin-jest/archive/f6f6d84c1134bc3d1aff9c2715e97d309e185bc3.tar.gz
info:    eslint-plugin-jest npm:| Project downloaded eslint-plugin-jest-0.0.0-development.tgz
info:    eslint-plugin-jest yarn:| yarn install started
warn:    eslint-plugin-jest yarn-install:| warning You are using Node "12.0.0-nightly20190313e6fa50e953" which is not supported and may encounter bugs or unexpected behavior. Yarn supports the following semver range: "^4.8.0 || ^5.7.0 || ^6.2.2 || >=8.0.0"
warn:    eslint-plugin-jest yarn-install:| warning "jest > jest-cli > @jest/core > jest-resolve-dependencies@24.4.0" has unmet peer dependency "jest-resolve@^24.1.0".
warn:    eslint-plugin-jest yarn-install:| warning "jest > jest-cli > jest-config > jest-resolve@24.4.0" has unmet peer dependency "jest-haste-map@^24.0.0".
info:    eslint-plugin-jest yarn:| yarn install successfully completed
info:    eslint-plugin-jest yarn:| test suite started
info:    passing module(s)   |
info:    module name:        | eslint-plugin-jest
info:    version:            | 22.3.2
info:    done                | The smoke test has passed.
info:    duration            | test duration: 14401ms
Checklist
  • contribution guidelines followed
    here

This is mostly to have a code base using Jest. It would be preferable to
include Jest itself instead. See #684
@SimenB SimenB mentioned this pull request Mar 13, 2019
@codecov-io
Copy link

codecov-io commented Mar 13, 2019

Codecov Report

Merging #686 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #686   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files          26       26           
  Lines         823      823           
=======================================
  Hits          777      777           
  Misses         46       46

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e14df6...25aae2a. Read the comment docs.

@richardlau
Copy link
Member

@BridgeAR
Copy link
Member

Looks like the CI passed on all platforms besides AIX.

@BridgeAR
Copy link
Member

@BridgeAR
Copy link
Member

@SimenB would you be so kind and skip this on AIX? It seems like yarn uses a functionality that does not exist on AIX before 7.1.

@SimenB
Copy link
Member Author

SimenB commented Mar 15, 2019

Done! (I think)

@BridgeAR
Copy link
Member

@targos targos merged commit c6edc9c into nodejs:master Mar 17, 2019
MylesBorins pushed a commit that referenced this pull request Mar 21, 2019
This is mostly to have a code base using Jest. It would be preferable to
include Jest itself instead. See #684.
@SimenB SimenB deleted the eslint-plugin-jest branch April 4, 2019 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants