lookup: unskip bluebird, bson and radium

[targos]

They pass on my machine.

Do we have a way test 3 modules in one CI run? @richardlau

[richardlau]

Do we have a way test 3 modules in one CI run? @richardlau

Untested, but maybe --includeTags to citgm-all? The module names are available as tags:

citgm/lib/check-tags.js

Line 17 in 62ade10

mod.tags.push(name);

[codecov-io]

Codecov Report

Merging #729 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #729   +/-   ##
=======================================
  Coverage   96.22%   96.22%           
=======================================
  Files          27       27           
  Lines         875      875           
=======================================
  Hits          842      842           
  Misses         33       33

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62ade10...4f5194f. Read the comment docs.

[targos]

CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/72/

[targos]

New CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/73/

[targos]

It's green :)

[richardlau]

It's green :)

Only because everything was skipped? Looks like https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/73/ was run against citgm (i.e. with the skips) rather than targos/citgm#unskip.

[targos]

🤦‍♂

Better: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/74/console

Only Windows fails because npm puts a shell script at node_modules/.bin/_mocha instead of a symlink.
Should we skip the platform?

[BridgeAR]

@targos that's probably best. I wonder if it makes sense to add a comment field to our JSON entries to explain why we skip things. That way it becomes easier to unskip them as soon as a problem is resolved.

[targos]

Adding a general comment field to the lookup sound like a good idea

[targos]

New CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/75/console