Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: fix serialport #748

Closed
wants to merge 1 commit into from
Closed

lookup: fix serialport #748

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 30, 2019

The serialport fails across all platforms on which it is run during
CITGM runs against the current Node.js master branch. The fix for the
problem is (probably)
serialport/node-serialport@13c542b
which hasn't made it into a release yet. Run tests against the master
branch of serialport instead of the current release.

Checklist
  • npm test passes
  • contribution guidelines followed
    here

The serialport fails across all platforms on which it is run during
CITGM runs against the current Node.js master branch. The fix for the
problem is (probably)
serialport/node-serialport@13c542b
which hasn't made it into a release yet. Run tests against the master
branch of serialport instead of the current release.
@Trott
Copy link
Member Author

Trott commented Aug 30, 2019

Example of a failure without this change:

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1986/nodes=debian8-64/testReport/junit/(root)/citgm/serialport_v7_1_5/

       > core-js@3.2.1 postinstall /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/bab6f54b-9535-40f1-8fe0-a957d2e61047/serialport/node_modules/core-js
 > node scripts/postinstall || echo "ignore"
 > serialport-monorepo@0.0.0 postinstall /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/bab6f54b-9535-40f1-8fe0-a957d2e61047/serialport
 > lerna bootstrap --no-ci
 lerna notice cli v3.16.4
 lerna info versioning independent
 lerna info Bootstrapping 17 packages
 lerna info Installing external dependencies
 lerna ERR! npm install exited 1 in '@serialport/bindings'
 lerna ERR! npm install stdout:
 > @serialport/bindings@2.0.8 install /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/bab6f54b-9535-40f1-8fe0-a957d2e61047/serialport/packages/bindings
 > node-gyp rebuild
 make: Entering directory '/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/bab6f54b-9535-40f1-8fe0-a957d2e61047/serialport/packages/bindings/build'
   CXX(target) Release/obj.target/bindings/src/serialport_unix.o
   CXX(target) Release/obj.target/bindings/src/serialport.o
   CXX(target) Release/obj.target/bindings/src/poller.o
 bindings.target.mk:112: recipe for target 'Release/obj.target/bindings/src/serialport.o' failed
 make: Leaving directory '/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/bab6f54b-9535-40f1-8fe0-a957d2e61047/serialport/packages/bindings/build'
 lerna ERR! npm install stderr:
 ../src/serialport.cpp: In function void EIO_AfterGet(uv_work_t*):
 ../src/serialport.cpp:329:96: error: no matching function for call to v8::Object::Set(v8::Local<v8::String>, Nan::imp::FactoryBase<v8::Boolean>::return_t)
      results->Set(Nan::New<v8::String>("cts").ToLocalChecked(), Nan::New<v8::Boolean>(data->cts));
                                                                                                 ^
 ../src/serialport.cpp:329:96: note: candidates are:
 In file included from /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/src/node.h:63:0,
                  from ../node_modules/nan/nan.h:54,
                  from ../src/./serialport.h:6,
                  from ../src/serialport.cpp:1:
 /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/deps/v8/include/v8.h:3327:51: note: v8::Maybe<bool> v8::Object::Set(v8::Local<v8::Context>, v8::Local<v8::Value>, v8::Local<v8::Value>)
    V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
                                                    ^
 /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/deps/v8/include/v8.h:3327:51: note:   candidate expects 3 arguments, 2 provided
 /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/deps/v8/include/v8.h:3330:51: note: v8::Maybe<bool> v8::Object::Set(v8::Local<v8::Context>, uint32_t, v8::Local<v8::Value>)
    V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,
                                                    ^
 /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/deps/v8/include/v8.h:3330:51: note:   candidate expects 3 arguments, 2 provided
 ../src/serialport.cpp:330:96: error: no matching function for call to v8::Object::Set(v8::Local<v8::String>, Nan::imp::FactoryBase<v8::Boolean>::return_t)
      results->Set(Nan::New<v8::String>("dsr").ToLocalChecked(), Nan::New<v8::Boolean>(data->dsr));
                                                                                                 ^
 ../src/serialport.cpp:330:96: note: candidates are:
 In file included from /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/src/node.h:63:0,
                  from ../node_modules/nan/nan.h:54,
                  from ../src/./serialport.h:6,
                  from ../src/serialport.cpp:1:
 /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/deps/v8/include/v8.h:3327:51: note: v8::Maybe<bool> v8::Object::Set(v8::Local<v8::Context>, v8::Local<v8::Value>, v8::Local<v8::Value>)
    V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
                                                    ^
 /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/deps/v8/include/v8.h:3327:51: note:   candidate expects 3 arguments, 2 provided
 /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/deps/v8/include/v8.h:3330:51: note: v8::Maybe<bool> v8::Object::Set(v8::Local<v8::Context>, uint32_t, v8::Local<v8::Value>)
    V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,
                                                    ^
 /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/deps/v8/include/v8.h:3330:51: note:   candidate expects 3 arguments, 2 provided
 ../src/serialport.cpp:331:96: error: no matching function for call to v8::Object::Set(v8::Local<v8::String>, Nan::imp::FactoryBase<v8::Boolean>::return_t)
      results->Set(Nan::New<v8::String>("dcd").ToLocalChecked(), Nan::New<v8::Boolean>(data->dcd));
                                                                                                 ^
 ../src/serialport.cpp:331:96: note: candidates are:
 In file included from /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/src/node.h:63:0,
                  from ../node_modules/nan/nan.h:54,
                  from ../src/./serialport.h:6,
                  from ../src/serialport.cpp:1:
 /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/deps/v8/include/v8.h:3327:51: note: v8::Maybe<bool> v8::Object::Set(v8::Local<v8::Context>, v8::Local<v8::Value>, v8::Local<v8::Value>)
    V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
                                                    ^
 /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/deps/v8/include/v8.h:3327:51: note:   candidate expects 3 arguments, 2 provided
 /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/deps/v8/include/v8.h:3330:51: note: v8::Maybe<bool> v8::Object::Set(v8::Local<v8::Context>, uint32_t, v8::Local<v8::Value>)
    V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,
                                                    ^
 /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/deps/v8/include/v8.h:3330:51: note:   candidate expects 3 arguments, 2 provided
 ../src/serialport.cpp: In function void EIO_AfterGetBaudRate(uv_work_t*):
 ../src/serialport.cpp:378:106: error: no matching function for call to v8::Object::Set(v8::Local<v8::String>, Nan::imp::IntegerFactory<v8::Integer>::return_t)
      results->Set(Nan::New<v8::String>("baudRate").ToLocalChecked(), Nan::New<v8::Integer>(data->baudRate));
                                                                                                           ^
 ../src/serialport.cpp:378:106: note: candidates are:
 In file included from /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/src/node.h:63:0,
                  from ../node_modules/nan/nan.h:54,
                  from ../src/./serialport.h:6,
                  from ../src/serialport.cpp:1:
 /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/deps/v8/include/v8.h:3327:51: note: v8::Maybe<bool> v8::Object::Set(v8::Local<v8::Context>, v8::Local<v8::Value>, v8::Local<v8::Value>)
    V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
                                                    ^
 /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/deps/v8/include/v8.h:3327:51: note:   candidate expects 3 arguments, 2 provided
 /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/deps/v8/include/v8.h:3330:51: note: v8::Maybe<bool> v8::Object::Set(v8::Local<v8::Context>, uint32_t, v8::Local<v8::Value>)
    V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,
                                                    ^
 /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/deps/v8/include/v8.h:3330:51: note:   candidate expects 3 arguments, 2 provided
 make: *** [Release/obj.target/bindings/src/serialport.o] Error 1
 make: *** Waiting for unfinished jobs....
 gyp ERR! build error 
 gyp ERR! stack Error: `make` failed with exit code: 2
 gyp ERR! stack     at ChildProcess.onExit (/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/smoker/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:196:23)
 gyp ERR! stack     at ChildProcess.emit (events.js:209:13)
 gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)
 gyp ERR! System Linux 3.16.0-6-amd64
 gyp ERR! command "/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/smoker/bin/node" "/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/smoker/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
 gyp ERR! cwd /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/bab6f54b-9535-40f1-8fe0-a957d2e61047/serialport/packages/bindings
 gyp ERR! node -v v13.0.0-pre
 gyp ERR! node-gyp -v v5.0.3
 gyp ERR! not ok 
 npm ERR! code ELIFECYCLE
 npm ERR! errno 1
 npm ERR! @serialport/bindings@2.0.8 install: `node-gyp rebuild`
 npm ERR! Exit status 1
 npm ERR! 
 npm ERR! Failed at the @serialport/bindings@2.0.8 install script.
 npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
 npm ERR! A complete log of this run can be found in:
 npm ERR!     /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/npm_cache/_logs/2019-08-29T18_00_04_814Z-debug.log
 lerna ERR! npm install exited 1 in '@serialport/bindings'
 lerna WARN complete Waiting for 1 child process to exit. CTRL-C to exit immediately.
 npm ERR! code ELIFECYCLE
 npm ERR! errno 1
 npm ERR! serialport-monorepo@0.0.0 postinstall: `lerna bootstrap --no-ci`
 npm ERR! Exit status 1
 npm ERR! 
 npm ERR! Failed at the serialport-monorepo@0.0.0 postinstall script.
 npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
 npm ERR! A complete log of this run can be found in:
 npm ERR!     /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/npm_cache/_logs/2019-08-29T18_00_04_974Z-debug.log

@Trott
Copy link
Member Author

Trott commented Aug 30, 2019

FYI @reconbot

@codecov-io
Copy link

codecov-io commented Aug 30, 2019

Codecov Report

Merging #748 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #748   +/-   ##
=======================================
  Coverage   96.22%   96.22%           
=======================================
  Files          27       27           
  Lines         874      874           
=======================================
  Hits          841      841           
  Misses         33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27e267f...20725fe. Read the comment docs.

@reconbot
Copy link
Contributor

🤔

@reconbot
Copy link
Contributor

8.0.0 will probably be out in a month or so

@Trott
Copy link
Member Author

Trott commented Aug 30, 2019

Windows failure on Travis is a known and unrelated issue, IIUC. I think this is ready for reviews? @nodejs/citgm

@Trott
Copy link
Member Author

Trott commented Oct 28, 2019

serialport 8 is out and all is well with it in CITGM. Closing!

@Trott Trott closed this Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants