Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lookup: add top depended modules from NPM #97

Closed
wants to merge 2 commits into from
Closed

lookup: add top depended modules from NPM #97

wants to merge 2 commits into from

Conversation

MylesBorins
Copy link
Contributor

this includes:

  • async
  • bluebird
  • mkdirp
  • yeoman-generator
  • minimist
  • cheerio
  • node-uuid
  • winston
  • yargs
  • semver
  • mime

@jasnell
Copy link
Member

jasnell commented Mar 22, 2016

LGTM

@MylesBorins MylesBorins force-pushed the top-modules branch 2 times, most recently from 01193d2 to ddf9639 Compare March 28, 2016 23:21
@MylesBorins
Copy link
Contributor Author

citgm: https://ci.nodejs.org/job/thealphanerd-smoker/179/
v5: https://ci.nodejs.org/job/thealphanerd-smoker/181/
v4: https://ci.nodejs.org/job/thealphanerd-smoker/182/

@MylesBorins
Copy link
Contributor Author

LOL... looks like grunt updated to v1 broke almost everything.

Time to clean up

edit: looks like a bug in grunt itself... there is a fix in, although it is still broken. I've posted in the PR with a solution.
gruntjs/grunt#1500

I've also sent a PR to moment to fix their dev stack moment/moment#3092

@shama
Copy link

shama commented Apr 5, 2016

Sorry about the breakages! We have published 1.0.1 with a fix. Thanks for your help @thealphanerd!

@MylesBorins
Copy link
Contributor Author

my pleasure @shama thanks for the quick turn around!

edit: this is the point of this project :p

@MylesBorins
Copy link
Contributor Author

This has been rebased on top of #126 in order to get more granular flaky support... let's test all the things!

master: https://ci.nodejs.org/view/Node.js-citgm/job/thealphanerd-smoker/223/
v6.0.0: https://ci.nodejs.org/view/Node.js-citgm/job/thealphanerd-smoker/224/
v5.11.0: https://ci.nodejs.org/view/Node.js-citgm/job/thealphanerd-smoker/225/
v4.4.3: https://ci.nodejs.org/view/Node.js-citgm/job/thealphanerd-smoker/226/
v0.12.13: https://ci.nodejs.org/view/Node.js-citgm/job/thealphanerd-smoker/227/
v0.10.44: https://ci.nodejs.org/view/Node.js-citgm/job/thealphanerd-smoker/228/

@MylesBorins
Copy link
Contributor Author

mkdirp failures on v6 / master are related to tschaub/mock-fs#107

lookup: add top depended modules from NPM
85dcf40 
this includes:
  * async
  * bluebird
  * mkdirp
  * yeoman-generator
  * minimist
  * cheerio
  * node-uuid
  * winston
  * yargs
  * semver
  * mime
@MylesBorins MylesBorins force-pushed the top-modules branch 2 times, most recently from 39066fc to 6e18a97 Compare April 30, 2016 01:11
@MylesBorins
Copy link
Contributor Author

one last CI run on master: https://ci.nodejs.org/view/Node.js-citgm/job/thealphanerd-smoker/230/
if this is good then I'm going to merge these changes. We can fix other problems as they arise

@MylesBorins
Copy link
Contributor Author

landed in e761c99...2e708ce

@MylesBorins MylesBorins closed this May 3, 2016
@MylesBorins MylesBorins deleted the top-modules branch June 28, 2016 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MylesBorins @jasnell @shama