feat: build wasm in common wasm-builder #105
Conversation
|
This action https://github.com/nodejs/cjs-module-lexer/blob/main/.github/workflows/build.yml might need an update if there is any setup required to use docker (I'm not sure if there is or not, we'll find out as soon as the action runs). Either way it likely needs an update to remove the steps that install the wasi sdk etc. as they will no longer be needed after this PR lands. |
|
@guybedford FYI as discussed. Have already moved over undici and amaro, so the cjs-module-lexer is the last one. |
|
Looks lioke the test will never run as its trying to use ubuntu18, opened #106 to fix that. In addition I think this will be needed in the action: Once #106 lands I'll rebase and then update the action to add this as well as remove the parts that are no longer needed. |
Refs: nodejs/security-wg#1236 Update to build in docker using wasm-builder image maintained in https://github.com/nodejs/wasm-builder. As a side effect this also updates the versions of the wasm tools to a newer version. undici and amaro have already been moved over and I plan to document in Node.js docs that this is the projects standard way to build WASM blobs. Signed-off-by: Michael Dawson <midawson@redhat.com>
mhdawson
force-pushed
the
common-wasm-builder
branch
from
bafd138 to
731b4cb
Compare
|
@guybedford just needed one small tweak to create the dist directory if it does not exist and build/tests pass. |
Refs: nodejs/security-wg#1236
Update to build in docker using wasm-builder image maintained in https://github.com/nodejs/wasm-builder.
As a side effect this also updates the versions of the wasm tools to a newer version.
undici and amaro have already been moved over and I plan to document in Node.js docs that this is the projects standard way to build WASM blobs.