lib: add cli to valid subsystems #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
approved these changes
Oct 23, 2019
addaleax
approved these changes
Oct 23, 2019
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
=======================================
Coverage 60.49% 60.49%
=======================================
Files 18 18
Lines 448 448
=======================================
Hits 271 271
Misses 177 177
Continue to review full report at Codecov.
|
targos
approved these changes
Oct 24, 2019
Trott
reviewed
Oct 24, 2019
Trott
approved these changes
Oct 24, 2019
|
Who has merge access for this repo? I'm happy to land but i don't think i can 🤔 |
|
Merged it but I can't publish to npm. (Anyone want to add me to |
|
Published in v3.12.1. |
|
@Trott I've added you as a maintainer of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs nodejs/node#30094.
Adds
clito the list of valid subsystems.cc @addaleax