Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid symlinks to work on Windows #13

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Sep 29, 2020

What's the problem this PR addresses?

The use of symlinks caused permission issues on Windows, and they aren't really necessary as we can just spawn the files directly

How did you fix it?

Avoid symlinks and just spawn the files directly

@merceyz merceyz marked this pull request as ready for review September 29, 2020 20:27
@arcanis arcanis merged commit b56df30 into nodejs:master Sep 29, 2020
@merceyz merceyz deleted the merceyz/avoid-symlinks branch September 29, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants