Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DESIGN.md s/engines.pm/packageManager/ #141

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Update DESIGN.md s/engines.pm/packageManager/ #141

merged 1 commit into from
Jul 21, 2022

Conversation

x11x
Copy link
Contributor

@x11x x11x commented Jul 7, 2022

#140

I just did a find and replace of "engines.pm to packageManager". Also it seems the version has to be 2.0.0 not ^2.0.0
I don't know whether anything else has changed since this document was written.

Maybe "Envisioned workflow" etc. needs to be changed if it is no longer a proposal and is now released.

#140

I just did a find and replace of "engines.pm to packageManager". Also it seems the version has to be 2.0.0 not ^2.0.0
I don't know whether anything else has changed since this document was written.

Maybe "Envisioned workflow" etc. needs to be changed if it is no longer a proposal and is now released.
@styfle
Copy link
Member

styfle commented Jul 7, 2022

For posterity, I think it would be good to update the document to explain why engines.pm was changed to packageManger rather than trying to dig through all the old issues in this repo.

@aduh95 aduh95 merged commit d6039c5 into nodejs:main Jul 21, 2022
@x11x x11x deleted the patch-1 branch August 5, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants