doc: add minutes for meeting 2020-02-12 #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-github
reviewed
Feb 12, 2020
| * Number is separate because a major Node.js version might not change the | ||
| report format. It's easier for tools consuming the report to deal with a | ||
| sequential number separated from the Node.js version | ||
| * N-API also has its own version not tied to Node.js version |
There was a problem hiding this comment.
as does the node.js ABI, process.versions.modules - https://nodejs.org/api/process.html#process_process_versions
cjihrig
approved these changes
Feb 12, 2020
| nobody looks at it. | ||
| * Matheus: that could work | ||
| * Michael: what would be the reasonable time for this auto approval window? | ||
| * Mattheus: how about 3-4 days? |
There was a problem hiding this comment.
How about 7 days, since that is the amount of time required in nodejs/node with a single approval.
mhdawson
reviewed
Feb 14, 2020
mhdawson
reviewed
Feb 14, 2020
mhdawson
reviewed
Feb 14, 2020
mhdawson
approved these changes
Feb 14, 2020
|
ping @mmarchini (some review comments to be addressed it seems) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #354