Update npm to v2.14.21 for the 0.10 image #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds reasonable @chorrell. LGTM |
|
I'm going to put this on hold for a little bit pending the outcome of nodejs/node#5570 |
|
Also see nodejs/node#5593 Looks like 0.10 will get 2.14.21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates npm for the 0.10 image to v2.14.21.
Node.js 0.10 is now in Maintenance mode which means that npm will not be updated in any future release of the Node.js package. In the early days of the Docker Node.js image, the version of npm would be updated periodically to the latest version. We no longer do that per our discussion in #64. At the time we decided to stop updating npm in the 0.10 variant and eventually remove the update logic from the respective Docker files when npm 2 was included with v0.10.x (at the time it looked like that would happen with 0.10.42 or 0.10.43) .
I think at this point we might as well update to the latest npm 2 release which is v2.14.21. That should not be a breaking change in anyway. Also, since we've always provided a 0.10 image with some version of npm 2 it seems reasonable to at least provide the latest release.
Also note that I'm removing the old update-npm.sh script we used to use to update npm. It's not really relevant anymore as I don't expect to be updating the npm version for the 0.10 image that often.
See: