Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: chmod bullseye entrypoint script #1545

Merged
merged 1 commit into from
Aug 17, 2021
Merged

fix: chmod bullseye entrypoint script #1545

merged 1 commit into from
Aug 17, 2021

Conversation

nschonni
Copy link
Member

Description

Motivation and Context

Testing Details

Example Output(if appropriate)

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Others (non of above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@nschonni nschonni requested a review from a team August 17, 2021 01:29
@nschonni
Copy link
Member Author

Think the missing bit is causing the failures in docker-library/official-images#10740

@nschonni nschonni mentioned this pull request Aug 17, 2021
Closed
tianon
tianon approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👀

@SimenB SimenB merged commit 52991e7 into nodejs:main Aug 17, 2021
@github-actions
Copy link

Created PR on the official-images repo (docker-library/official-images#10740). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

@nschonni nschonni deleted the chmod branch August 17, 2021 12:22
@nodejs-github-bot nodejs-github-bot mentioned this pull request Aug 17, 2021
Merged
@github-actions
Copy link

Created PR on the official-images repo (docker-library/official-images#10748). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimenB SimenB SimenB approved these changes

@tianon tianon tianon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nschonni @tianon @SimenB