Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the 'lts' and 'current' tags #930

Merged
merged 1 commit into from
Nov 25, 2018
Merged

Conversation

LaurentGoderre
Copy link
Member

Fixes #527

@LaurentGoderre
Copy link
Member Author

This generates

# this file is generated via https://github.com/nodejs/docker-node/blob/216f736fc3f5cdc5522dcf91aba0ff28d0701ea7/generate-stackbrew-library.sh

Maintainers: The Node.js Docker Team <https://github.com/nodejs/docker-node> (@nodejs)
GitRepo: https://github.com/nodejs/docker-node.git

Tags: 8.13.0-jessie, 8.13-jessie, 8-jessie, carbon-jessie
Architectures: arm32v7, amd64, i386
GitCommit: 0ceefee0745a078709c60d92e4229f5eb6a3df42
Directory: 8/jessie

Tags: 8.13.0-alpine, 8.13-alpine, 8-alpine, carbon-alpine
Architectures: arm32v6, arm64v8, amd64, i386, ppc64le, s390x
GitCommit: 28932215645dbdc08ea1a8f360557d4490d0207c
Directory: 8/alpine

Tags: 8.13.0-onbuild, 8.13-onbuild, 8-onbuild, carbon-onbuild
Architectures: arm32v7, arm64v8, amd64, i386, ppc64le, s390x
GitCommit: 0ceefee0745a078709c60d92e4229f5eb6a3df42
Directory: 8/onbuild

Tags: 8.13.0-slim, 8.13-slim, 8-slim, carbon-slim
Architectures: arm32v7, arm64v8, amd64, i386, ppc64le, s390x
GitCommit: 0ceefee0745a078709c60d92e4229f5eb6a3df42
Directory: 8/slim

Tags: 8.13.0-stretch, 8.13-stretch, 8-stretch, carbon-stretch, 8.13.0, 8.13, 8, carbon
Architectures: arm32v7, arm64v8, amd64, i386, ppc64le, s390x
GitCommit: 0ceefee0745a078709c60d92e4229f5eb6a3df42
Directory: 8/stretch

Tags: 6.14.4-jessie, 6.14-jessie, 6-jessie, boron-jessie
Architectures: arm32v7, amd64, i386
GitCommit: 8ccd57c1457a1b47adc4d82f9fed9ad51ccef3c5
Directory: 6/jessie

Tags: 6.14.4-alpine, 6.14-alpine, 6-alpine, boron-alpine
Architectures: amd64
GitCommit: 28932215645dbdc08ea1a8f360557d4490d0207c
Directory: 6/alpine

Tags: 6.14.4-onbuild, 6.14-onbuild, 6-onbuild, boron-onbuild
Architectures: arm32v7, amd64, i386
GitCommit: 72dd945d29dee5afa73956ebc971bf3a472442f7
Directory: 6/onbuild

Tags: 6.14.4-slim, 6.14-slim, 6-slim, boron-slim
Architectures: arm32v7, amd64, i386
GitCommit: 8ccd57c1457a1b47adc4d82f9fed9ad51ccef3c5
Directory: 6/slim

Tags: 6.14.4-stretch, 6.14-stretch, 6-stretch, boron-stretch, 6.14.4, 6.14, 6, boron
Architectures: arm32v7, arm64v8, amd64, i386, ppc64le, s390x
GitCommit: 8ccd57c1457a1b47adc4d82f9fed9ad51ccef3c5
Directory: 6/stretch

Tags: 11.2.0-alpine, 11.2-alpine, 11-alpine, current-alpine, alpine
Architectures: arm32v6, arm64v8, amd64, i386, ppc64le, s390x
GitCommit: 28932215645dbdc08ea1a8f360557d4490d0207c
Directory: 11/alpine

Tags: 11.2.0-slim, 11.2-slim, 11-slim, current-slim, slim
Architectures: arm32v7, arm64v8, amd64, ppc64le, s390x
GitCommit: 8ccd57c1457a1b47adc4d82f9fed9ad51ccef3c5
Directory: 11/slim

Tags: 11.2.0-stretch, 11.2-stretch, 11-stretch, current-stretch, stretch, 11.2.0, 11.2, 11, current, latest
Architectures: arm32v7, arm64v8, amd64, ppc64le, s390x
GitCommit: 8ccd57c1457a1b47adc4d82f9fed9ad51ccef3c5
Directory: 11/stretch

Tags: 10.13.0-jessie, 10.13-jessie, 10-jessie, dubnium-jessie, lts-jessie
Architectures: arm32v7, amd64
GitCommit: 8ccd57c1457a1b47adc4d82f9fed9ad51ccef3c5
Directory: 10/jessie

Tags: 10.13.0-alpine, 10.13-alpine, 10-alpine, dubnium-alpine, lts-alpine
Architectures: arm32v6, arm64v8, amd64, i386, ppc64le, s390x
GitCommit: 28932215645dbdc08ea1a8f360557d4490d0207c
Directory: 10/alpine

Tags: 10.13.0-slim, 10.13-slim, 10-slim, dubnium-slim, lts-slim
Architectures: arm32v7, amd64
GitCommit: 8ccd57c1457a1b47adc4d82f9fed9ad51ccef3c5
Directory: 10/slim

Tags: 10.13.0-stretch, 10.13-stretch, 10-stretch, dubnium-stretch, lts-stretch, 10.13.0, 10.13, 10, dubnium, lts
Architectures: arm32v7, arm64v8, amd64, ppc64le, s390x
GitCommit: 8ccd57c1457a1b47adc4d82f9fed9ad51ccef3c5
Directory: 10/stretch

Tags: chakracore-8.11.1, chakracore-8.11, chakracore-8
Architectures: amd64
GitCommit: 8ccd57c1457a1b47adc4d82f9fed9ad51ccef3c5
Directory: chakracore/8

Tags: chakracore-10.13.0, chakracore-10.13, chakracore-10, chakracore
Architectures: amd64
GitCommit: 69c8a5f448f46f9e34d7fb577eca79ba01f6864d
Directory: chakracore/10

@nschonni
Copy link
Member

I get why people ask for this, but there are 3 LTS releases currently so I don't think this tag will work https://github.com/nodejs/Release

@LaurentGoderre
Copy link
Member Author

People are asking for the latest lts to be lts

@SimenB
Copy link
Member

SimenB commented Nov 23, 2018

Should latest point to lts?

@chorrell
Copy link
Contributor

No, it should follow the normal convention of always pointing to the latest version

@LaurentGoderre
Copy link
Member Author

I think this way is kind of good way to tackle this. We implement lts and current as defined by Node and we use latest as is the default in the docker world so we get the best of both worlds

@SimenB SimenB merged commit 1d770f3 into nodejs:master Nov 25, 2018
@SimenB
Copy link
Member

SimenB commented Nov 25, 2018

@tianon
Copy link
Contributor

tianon commented Nov 26, 2018

Mirroring my comment from docker-library/official-images#5102 (comment):

What's the purpose of the node:current alias? Isn't that already what node:latest is?

@LaurentGoderre
Copy link
Member Author

@tianon perhaps but it's using the naming convention that node uses on its site.

@SimenB
Copy link
Member

SimenB commented Nov 28, 2018

Yeah, I answered in docker-library/official-images#5102 (comment) 🙂

@LaurentGoderre LaurentGoderre deleted the lts-tag branch December 5, 2018 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants