add building-node-with-ninja.md #38
Conversation
|
Cool, thanks! Just a note: having the 2 sections covering the 4 steps feels a little weird to me. Reading it from the top down, as someone that hasn't read it before, I can see someone running the quoted steps in the first block and getting frustrated when it doesn't work how they thought it would. Then they'd get to the next block and realize that was the part they actually needed to be reading. Perhaps it would be better to mix the two blocks together, putting the explanation bits from the first section in with the explicit instructional bits of the second. |
|
Closing this since docs aren't intended to live here anymore. Maybe redo the PR against |
|
note to self: do this |
|
@bengl Ah — I think we're pointing folks at PR'ing this material into nodejs/node itself now (ideally into |
PR-URL: nodejs#4767 Refs: nodejs/docs#38 Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Stephan Belanger <admin@stephenbelanger.com>
PR-URL: #4767 Refs: nodejs/docs#38 Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Stephan Belanger <admin@stephenbelanger.com>
PR-URL: #4767 Refs: nodejs/docs#38 Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Stephan Belanger <admin@stephenbelanger.com>
PR-URL: #4767 Refs: nodejs/docs#38 Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Stephan Belanger <admin@stephenbelanger.com>
PR-URL: #4767 Refs: nodejs/docs#38 Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Stephan Belanger <admin@stephenbelanger.com>
PR-URL: #4767 Refs: nodejs/docs#38 Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Stephan Belanger <admin@stephenbelanger.com>
People always ask me about how to do this, and there's no info about it really anywhere.
R=@nodejs/documentation