Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

modules: remove file extension and directory resolving for esm #2

Closed
wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

this build on top of the limitations of the package name map proposal.
It removes file extensions and directory resolution in the resolver.

This is only currently limited for local development. When resolving
dependencies file extension and directory resolution will still work.

Refs: https://github.com/domenic/package-name-maps

Moved from nodejs/node#21729

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

michael-ciniawsky

This comment was marked as off-topic.

devsnek

This comment was marked as off-topic.

@devsnek
Copy link
Member

devsnek commented Aug 23, 2018

i'd like to make sure we have this repo set up to automatically pull updates from nodejs/node before we're merging changes

ljharb

This comment was marked as off-topic.

@bmeck
Copy link
Member

bmeck commented Aug 27, 2018

We have people discussing the continues use of bundlers in #1 and not focusing on web compatibility since they can continue to use the solutions bundlers provide. If that is the mentality we don't need to do this PR since resolution could be provided by ahead of time tools like bundlers.

Additionally, given the package name maps approach and proof of creating maps that support index files, extension completion, etc. I don't see the need for this PR even with people wanting to use bundlers if they want to manually make package name maps, or using a different tool.

bmeck

This comment was marked as off-topic.

this build on top of the limitations of the package name map proposal.
It removes file extensions and directory resolution in the resolver.

This is only currently limited for local development. When resolving
dependencies file extension and directory resolution will still work.

Refs: https://github.com/domenic/package-name-maps
@MylesBorins
Copy link
Contributor Author

Closing in lieu of #6

@MylesBorins MylesBorins closed this Oct 2, 2018
@ljharb ljharb deleted the simplified-esm-resolver branch October 2, 2018 06:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants