-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lite-ci): disable lite-ci #268
Conversation
Removes minimum amount of code necessary to disable Lite-CI from triggering (while also passing tests and linters). Lite-CI doesn't work anymore and now we have Actions testing on multiple platforms and running linters, therefore we also don't need Lite-CI anymore. There might be some leftover code related to Lite-CI, but this fixes the immediate issue.
@nodejs/citgm are you folks using @nodejs-github-bot to kick off CI with a comment anymore? Asking cause deleting |
I never started CITGM via comment, had no idea it was an option, and never saw anyone doing it :) But if folks are using it I can reduce the scope of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with feedback from CITGM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never used that feature for citgm (didn't know about it)
FWIW I made a small fix to the lite-ci pipeline: nodejs/node#34531 (comment) re. citgm, I can't remember the last time I used that feature, or if it still works. (Or, for that matter, whether it triggered the job to test CITGM itself or the job to test lookup.json changes.) If we do want that feature I've a soft preference to adopting the add a label to start CI mechanism that was recently added for core. |
I think we should just remove lite-ci from Jenkins. Since we started adding more Actions it doesn't bring any value to us and it ends up being one more Jenkins job to maintain (I'm not even sure if it is working, the last run took only five minutes). |
I have no objections. I think the only reasons people run lite-ci is they're either not up to date with policy (just Actions are adequate for doc-only PRs) or are trying to silence (five minutes is plausible, the lite job only runs the linters and build/test on LinuxONE which can complete that quickly if there are no code changes and a populated ccache.) |
I'll try to get ncu to recognize Actions as well (we should be requiring it to succeed anyway since we have tests that only run there) |
Removes minimum amount of code necessary to disable Lite-CI from
triggering (while also passing tests and linters). Lite-CI doesn't work
anymore and now we have Actions testing on multiple platforms and
running linters, therefore we also don't need Lite-CI
anymore. There might be some leftover code related to Lite-CI, but this
fixes the immediate issue.